-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels to the nodes created via Machines #116
Conversation
In the "MachineSpec" one can specify the labels, taints. In this patch we use the kubelet args to bootstrap the node with the provided taints and labels Resolves #111 Change-Id: Id184e1148c8f6149c9faa40cb382bf740210bba5
Hi @sidharthsurana. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@sidharthsurana when user input labels or taint? i could not find anything on machineSpec |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frapposelli, sidharthsurana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rnetes-sigs#116) Signed-off-by: Vince Prignano <vince@vincepri.com>
In the
Machine
one can specify the labels, taints. In this patch we use the kubelet args to bootstrap the node with the provided taints and labelsResolves #111
Change-Id: Id184e1148c8f6149c9faa40cb382bf740210bba5