Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Node Labels and Taints on the nodes #111

Closed
sidharthsurana opened this issue Nov 7, 2018 · 0 comments
Closed

Enable Node Labels and Taints on the nodes #111

sidharthsurana opened this issue Nov 7, 2018 · 0 comments

Comments

@sidharthsurana
Copy link
Contributor

This is a child Issue of Issue#493 on the main cluster-api repo.

In this Issue we want to handle the labeling and taints on the node created using the vsphere provider implementation.
Based on the discussion on the cluster-api sig call, we would implement this using kubelet args for now. Once the broader sig has consensus over a better approach, we will switch to using that mechanism.

So, the behavior this Issue is trying to address is that when a user specifies a set of taints and labels inside the Machine object, these should be applied on the node created using the spec. These labels and taints however are only to be applied initially. Changing theses on the Machine object on a day-2 basis will not be reconciled back with the actual Node object for now.

sidharthsurana added a commit that referenced this issue Nov 8, 2018
In the "MachineSpec" one can specify the labels, taints. In this
patch we use the kubelet args to bootstrap the node with the provided
taints and labels

Resolves #111
Change-Id: Id184e1148c8f6149c9faa40cb382bf740210bba5
k8s-ci-robot pushed a commit that referenced this issue Nov 9, 2018
In the "MachineSpec" one can specify the labels, taints. In this
patch we use the kubelet args to bootstrap the node with the provided
taints and labels

Resolves #111
Change-Id: Id184e1148c8f6149c9faa40cb382bf740210bba5
jayunit100 pushed a commit to jayunit100/cluster-api-provider-vsphere that referenced this issue Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant