Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add GET gophercloud metrics #932

Merged
merged 1 commit into from
Jul 14, 2021
Merged

✨ Add GET gophercloud metrics #932

merged 1 commit into from
Jul 14, 2021

Conversation

tobiasgiese
Copy link
Member

@tobiasgiese tobiasgiese commented Jul 9, 2021 •
edited
Loading

Signed-off-by: Tobias Giese [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #856

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

Tobias Giese [email protected], Daimler TSS GmbH, legal info/Impressum

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @tobiasgiese. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2021
@chrischdi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2021
chrischdi
chrischdi reviewed Jul 12, 2021
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all lgtm except at least the capoerrors.IsNotFound parts :-)

Thanks for contributing 👍

pkg/cloud/services/compute/instance.go Show resolved Hide resolved
pkg/cloud/services/compute/instance.go Show resolved Hide resolved
chrischdi
chrischdi reviewed Jul 12, 2021
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the other places.

pkg/cloud/services/compute/instance.go Show resolved Hide resolved
@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-metrics branch from b896ca4 to dc0128f Compare July 12, 2021 07:11
chrischdi
chrischdi reviewed Jul 12, 2021
View reviewed changes
pkg/cloud/services/networking/router.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-metrics branch from dc0128f to ba9582c Compare July 12, 2021 09:27
chrischdi
chrischdi reviewed Jul 12, 2021
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@hidekazuna
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, hidekazuna, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2021
seanschneeweiss
seanschneeweiss reviewed Jul 13, 2021
View reviewed changes
Copy link
Contributor

@seanschneeweiss seanschneeweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest some prefixes to the metric names to keep it sync with kubernetes/cloud-provider-openstack.

pkg/cloud/services/compute/instance.go Outdated Show resolved Hide resolved
pkg/cloud/services/compute/instance.go Outdated Show resolved Hide resolved
pkg/cloud/services/loadbalancer/loadbalancer.go Outdated Show resolved Hide resolved
pkg/cloud/services/loadbalancer/loadbalancer.go Outdated Show resolved Hide resolved
pkg/cloud/services/loadbalancer/loadbalancer.go Outdated Show resolved Hide resolved
pkg/cloud/services/loadbalancer/loadbalancer.go Outdated Show resolved Hide resolved
pkg/cloud/services/loadbalancer/loadbalancer.go Outdated Show resolved Hide resolved
@tobiasgiese
Add GET gophercloud metrics
f459bbc 
Signed-off-by: Tobias Giese <[email protected]>
@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-metrics branch from ba9582c to f459bbc Compare July 13, 2021 14:28
@tobiasgiese
Copy link
Member Author

I suggest some prefixes to the metric names to keep it sync with kubernetes/cloud-provider-openstack.

Thanks, added all the findings

@tobiasgiese
Copy link
Member Author

/retest

@jichenjc
Copy link
Contributor

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit c73f022 into kubernetes-sigs:master Jul 14, 2021
@tobiasgiese tobiasgiese deleted the tobiasgiese/add-metrics branch July 14, 2021 07:08
@tobiasgiese tobiasgiese mentioned this pull request Jul 16, 2021
Closed
6 tasks
@macaptain macaptain mentioned this pull request Jul 16, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc jichenjc left review comments

@seanschneeweiss seanschneeweiss seanschneeweiss left review comments

@chrischdi chrischdi chrischdi left review comments

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose gophercloud requests metrics
6 participants
@tobiasgiese @k8s-ci-robot @chrischdi @hidekazuna @jichenjc @seanschneeweiss