-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose gophercloud requests metrics #856
Comments
/help |
@sbueringer: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
um... what do we want to expose? I knew |
@jichenjc I was mainly thinking about the 3 listed here: https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/metrics.md#openstack-api-calls They have served us well when monitoring/alerting cloud-provider-openstack in prod. |
ok, I can give a try as I did part of CPO metrics job |
Okay :) |
@jichenjc what is the current status here? Are you done with this issue or can I support you / take over? |
part of the metrics added at #863 there are some todo (e.g GET/query part) , if you like ,you can work on it at your convenience :) @tobiasgiese |
Okay, I'll take a look at it :) |
/kind feature
Describe the solution you'd like
A while back we contributed metrics about gophercloud requests to cloud-provider-openstack. I think it would be great to have the same metrics in CAPO
Anything else you would like to add:
Ref to the ccm PR: kubernetes/cloud-provider-openstack#1178
(this pr also adds reconcile metrics, I wouldn't do this for now, as controller-runtime already exposes those)
The text was updated successfully, but these errors were encountered: