Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose gophercloud requests metrics #856

Closed
sbueringer opened this issue May 6, 2021 · 9 comments · Fixed by #932
Closed

Expose gophercloud requests metrics #856

sbueringer opened this issue May 6, 2021 · 9 comments · Fixed by #932
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sbueringer
Copy link
Member

/kind feature

Describe the solution you'd like
A while back we contributed metrics about gophercloud requests to cloud-provider-openstack. I think it would be great to have the same metrics in CAPO

Anything else you would like to add:

Ref to the ccm PR: kubernetes/cloud-provider-openstack#1178
(this pr also adds reconcile metrics, I wouldn't do this for now, as controller-runtime already exposes those)

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 6, 2021
@sbueringer sbueringer changed the title Expose metrics about gophercloud requests Expose gophercloud requests metrics May 6, 2021
@sbueringer
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@sbueringer:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 6, 2021
@jichenjc
Copy link
Contributor

jichenjc commented May 7, 2021

um... what do we want to expose? I knew
https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/metrics.md
and it expose OCCM data, what kind of metrics we want to expose for CAPO? the CAPO API calls?

@sbueringer
Copy link
Member Author

sbueringer commented May 7, 2021

@jichenjc I was mainly thinking about the 3 listed here: https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/metrics.md#openstack-api-calls

They have served us well when monitoring/alerting cloud-provider-openstack in prod.

@jichenjc
Copy link
Contributor

jichenjc commented May 7, 2021

ok, I can give a try as I did part of CPO metrics job
/assign

@sbueringer
Copy link
Member Author

Okay :)

@tobiasgiese
Copy link
Member

@jichenjc what is the current status here? Are you done with this issue or can I support you / take over?

@jichenjc
Copy link
Contributor

jichenjc commented Jul 8, 2021

part of the metrics added at #863

there are some todo (e.g GET/query part) , if you like ,you can work on it at your convenience :) @tobiasgiese

@tobiasgiese
Copy link
Member

Okay, I'll take a look at it :)
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants