Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ NetworkFilter to NetworkParam #1972

Merged
merged 1 commit into from
Mar 28, 2024
Merged

⚠️ NetworkFilter to NetworkParam #1972

merged 1 commit into from
Mar 28, 2024

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Mar 26, 2024 •
edited
Loading

See #1975

TODO:

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from dulek and jichenjc March 26, 2024 17:38
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 26, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 26, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 73c81de
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6605663dbe40c000084b0cfb
😎 Deploy Preview https://deploy-preview-1972--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jichenjc
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-test

@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 27, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

This was referenced Mar 27, 2024
Merged
Merged
@mdbooth mdbooth force-pushed the networkparam branch 2 times, most recently from 9ab651c to 5ae53bf Compare March 27, 2024 17:01
@mdbooth mdbooth mentioned this pull request Mar 27, 2024
Merged
3 tasks
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 27, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth mdbooth mentioned this pull request Mar 27, 2024
Merged
5 tasks
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90
lentzi90 reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

api/v1alpha6/openstackcluster_conversion.go

// Restore all fields except ID, which should have been copied over in conversion
// ExternalNetwork by filter will be been lost in down-conversion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit, not worth a new push IMO, just mentioning since I happened to see it

Suggested change
// ExternalNetwork by filter will be been lost in down-conversion
// ExternalNetwork by filter will be lost in down-conversion

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
@mdbooth mdbooth mentioned this pull request Mar 28, 2024
Merged
5 tasks
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1d5d2d5 into kubernetes-sigs:main Mar 28, 2024
10 checks passed
@mdbooth mdbooth deleted the networkparam branch March 28, 2024 15:22
@huxcrux huxcrux mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@dulek dulek Awaiting requested review from dulek

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@lentzi90 lentzi90

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
CAPO Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdbooth @k8s-ci-robot @jichenjc @lentzi90