Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec.floatingIPNetwork in OpenStackFloatingIPPool no longer optional #1997

Closed
huxcrux opened this issue Apr 3, 2024 · 0 comments · Fixed by #1998
Closed

spec.floatingIPNetwork in OpenStackFloatingIPPool no longer optional #1997

huxcrux opened this issue Apr 3, 2024 · 0 comments · Fixed by #1998
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@huxcrux
Copy link
Contributor

huxcrux commented Apr 3, 2024

/kind bug

What steps did you take and what happened:
When reading the API spec floatingIPNetwork is listed as optional (https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/api/v1alpha1/openstackfloatingippool_types.go#L64-L66)

If I use 0.10.0-alpha.0 and not setting floatingIPNetwork i get the following error:

"error": "[OpenStackFloatingIPPool.infrastructure.cluster.x-k8s.io](http://openstackfloatingippool.infrastructure.cluster.x-k8s.io/) \"hux-lab1\" is invalid: spec.floatingIPNetwork: Invalid value: 0: spec.floatingIPNetwork in body should have at least 1 properties"}

This behaviour seems to have been changed in: #1972

What did you expect to happen:
floatingIPNetwork to be optional or for us to change it to required

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster API Provider OpenStack version (Or git rev-parse HEAD if manually built): 0.10.0-alpha.0
  • Cluster-API version: v1.6.3
  • OpenStack version: Ussuri
  • Minikube/KIND version: kind v0.21.0
  • Kubernetes version (use kubectl version): 1.29.1
  • OS (e.g. from /etc/os-release): Ubuntu 22.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Archived in project
2 participants