Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined port for the control plane for vpc #854

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Sep 12, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #842

Special notes for your reviewer:

Template which contains the user defined port for the Apiserver:

apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
  labels:
    cluster.x-k8s.io/cluster-name: ibm-vpc-1
  name: ibm-vpc-1
  namespace: default
spec:
  clusterNetwork:
    apiServerPort: 443
    pods:
      cidrBlocks:
      - 192.168.0.0/16
    serviceDomain: cluster.local
    services:
      cidrBlocks:
      - 10.128.0.0/12

spec->clusterNetwork->apiServerPort

Deployed cluster:

k cluster-info
Kubernetes control plane is running at https://8c6cb435-us-east.lb.appdomain.cloud:443
CoreDNS is running at https://8c6cb435-us-east.lb.appdomain.cloud:443/api/v1/namespaces/kube-system/services/kube-dns:dns/proxy

To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.

IBM Cloud Backend pool

image

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 12, 2022
@netlify
Copy link

netlify bot commented Sep 12, 2022

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 4df126e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/631eee3544d8570008a30aa2
😎 Deploy Preview https://deploy-preview-854--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2022
@mkumatag mkumatag changed the title User defined port for the control plane User defined port for the control plane for vpc Sep 12, 2022
@mkumatag
Copy link
Member Author

/retest

@mkumatag
Copy link
Member Author

/cc @Prajyot-Parab

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2022
@Prajyot-Parab
Copy link
Contributor

@mkumatag Need to update here as well -

@mkumatag
Copy link
Member Author

@mkumatag Need to update here as well -

We aren't changing anything with the backend pool because that depends on the KubeadmControlPlane spec, so there isn't a standard way to override the port address for the kubeadm configuration(for init).

Rightnow the changes we made is for the port used for apiserver exposed for the end user or the workers to join.

Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Prajyot-Parab
Copy link
Contributor

@mkumatag Need to update here as well -

We aren't changing anything with the backend pool because that depends on the KubeadmControlPlane spec, so there isn't a standard way to override the port address for the kubeadm configuration(for init).

Rightnow the changes we made is for the port used for apiserver exposed for the end user or the workers to join.

QQ - Do we need to ensure the port specified here (apiServerPort) should also be in list of ports to be added in backend pool right, for loadBalancer to function properly?

@k8s-ci-robot k8s-ci-robot merged commit 416bed6 into kubernetes-sigs:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use user defined port for the control plane
3 participants