-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User defined port for the control plane for vpc #854
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
/retest |
/cc @Prajyot-Parab |
9b7ddef
to
4df126e
Compare
@mkumatag Need to update here as well -
|
We aren't changing anything with the backend pool because that depends on the Rightnow the changes we made is for the port used for apiserver exposed for the end user or the workers to join. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
QQ - Do we need to ensure the port specified here (apiServerPort) should also be in list of ports to be added in backend pool right, for loadBalancer to function properly? |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #842
Special notes for your reviewer:
Template which contains the user defined port for the Apiserver:
spec->clusterNetwork->apiServerPort
Deployed cluster:
IBM Cloud Backend pool
Release note: