Remove unwanted logs (#846)

kubernetes-sigs · Sep 9, 2022 · ee9cd5d · ee9cd5d
1 parent ca098cd
commit ee9cd5d
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/cloud/scope/machine.go b/cloud/scope/machine.go
@@ -18,7 +18,6 @@ package scope
 
 import (
 	"context"
-	"fmt"
 
 	"github.com/IBM/go-sdk-core/v5/core"
 	"github.com/IBM/vpc-go-sdk/vpcv1"
@@ -154,13 +153,12 @@ func (m *MachineScope) CreateMachine() (*vpcv1.Instance, error) {
 	}
 
 	options.SetInstancePrototype(instancePrototype)
-	instance, response, err := m.IBMVPCClient.CreateInstance(options)
+	instance, _, err := m.IBMVPCClient.CreateInstance(options)
 	if err != nil {
 		record.Warnf(m.IBMVPCMachine, "FailedCreateInstance", "Failed instance creation - %v", err)
 	} else {
 		record.Eventf(m.IBMVPCMachine, "SuccessfulCreateInstance", "Created Instance %q", *instance.Name)
 	}
-	fmt.Printf("%v\n", response)
 	return instance, err
 }
 

diff --git a/controllers/ibmpowervsmachine_controller.go b/controllers/ibmpowervsmachine_controller.go
@@ -256,7 +256,6 @@ func (r *IBMPowerVSMachineReconciler) reconcileNormal(machineScope *scope.PowerV
 			machineScope.Info("PowerVS instance state is undefined", "state", *instance.Status, "instance-id", machineScope.GetInstanceID())
 			conditions.MarkUnknown(machineScope.IBMPowerVSMachine, infrav1beta1.InstanceReadyCondition, "", "")
 		}
-		machineScope.Info(*ins.PvmInstanceID)
 	}
 
 	// Requeue after 2 minute if machine is not ready to update status of the machine properly.

diff --git a/controllers/ibmvpcmachine_controller.go b/controllers/ibmvpcmachine_controller.go
@@ -196,7 +196,6 @@ func (r *IBMVPCMachineReconciler) reconcileNormal(machineScope *scope.MachineSco
 			}
 		}
 		machineScope.IBMVPCMachine.Status.Ready = true
-		machineScope.Info(*instance.ID)
 	}
 
 	return ctrl.Result{}, nil
-Original file line number
+Diff line change
@@ Expand Up @@
     			}
     		}
     		machineScope.IBMVPCMachine.Status.Ready = true
-    		machineScope.Info(*instance.ID)
     	}
     	return ctrl.Result{}, nil
@@ Expand Down @@