Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default to bare minimum resource values #604

Merged
merged 1 commit into from
Mar 24, 2022
Merged

set default to bare minimum resource values #604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/v1beta1/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import "k8s.io/apimachinery/pkg/util/validation/field"
func defaultIBMPowerVSMachineSpec(spec *IBMPowerVSMachineSpec) {

if spec.Memory == "" {
spec.Memory = "8"
spec.Memory = "4"
}
if spec.Processors == "" {
spec.Processors = "0.25"
Expand Down Expand Up @@ -63,6 +63,6 @@ func validateIBMPowerVSResourceReference(res IBMPowerVSResourceReference, resTyp

func defaultIBMVPCMachineSpec(spec *IBMVPCMachineSpec) {
if spec.Profile == "" {
spec.Profile = "bx2-4x16"
spec.Profile = "bx2-2x8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though there are few more profiles lower than this but in the balanced one this is the bare minimal one per info, will revisit this later if any more concerns..

/unhold

}
}