set default to bare minimum resource values #604
Conversation
Signed-off-by: Prajyot-Parab <[email protected]>
k8s-ci-robot
added
the
area/provider/ibmcloud
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
There was a problem hiding this comment.
/lgtm for powervs
/approve
/hold for @wentao-zh @jichenjc to review for vpc
k8s-ci-robot
added
the
do-not-merge/hold
|
/cc @wentao-zh |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -63,6 +63,6 @@ func validateIBMPowerVSResourceReference(res IBMPowerVSResourceReference, resTyp | |||
|
|
|||
| func defaultIBMVPCMachineSpec(spec *IBMVPCMachineSpec) { | |||
| if spec.Profile == "" { | |||
| spec.Profile = "bx2-4x16" | |||
| spec.Profile = "bx2-2x8" | |||
There was a problem hiding this comment.
Though there are few more profiles lower than this but in the balanced one this is the bare minimal one per info, will revisit this later if any more concerns..
/unhold
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Prajyot-Parab [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #499
Special notes for your reviewer:
/area provider/ibmcloud
Release note: