Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeletePolicy to IBMPowerVSImage Spec #566

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

Prajyot-Parab
Copy link
Contributor

Signed-off-by: Prajyot-Parab [email protected]

What this PR does / why we need it:

  • Add DeletePolicy to IBMPowerVSImage Spec

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #542

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Feb 17, 2022
@netlify
Copy link

netlify bot commented Feb 17, 2022

✔️ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

🔨 Explore the source changes: 84fa466

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/620f42458535b10007bde052

😎 Browse the preview: https://deploy-preview-566--kubernetes-sigs-cluster-api-ibmcloud.netlify.app

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2022
@Prajyot-Parab Prajyot-Parab force-pushed the import_image branch 2 times, most recently from d7086b0 to 4c69a39 Compare February 17, 2022 14:34
controllers/ibmpowervsimage_controller.go Outdated Show resolved Hide resolved
controllers/ibmpowervsimage_controller.go Outdated Show resolved Hide resolved
api/v1beta1/ibmpowervsimage_types.go Outdated Show resolved Hide resolved
controllers/ibmpowervsimage_controller.go Outdated Show resolved Hide resolved
controllers/ibmpowervsimage_controller.go Outdated Show resolved Hide resolved
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 988245f into kubernetes-sigs:main Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeletePolicy for IBMPowerVSImage
3 participants