Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeletePolicy for IBMPowerVSImage #542

Closed
mkumatag opened this issue Feb 5, 2022 · 1 comment · Fixed by #566
Closed

DeletePolicy for IBMPowerVSImage #542

mkumatag opened this issue Feb 5, 2022 · 1 comment · Fixed by #566
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@mkumatag
Copy link
Member

mkumatag commented Feb 5, 2022

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
By default the images associated with the resource from the cloud will get deleted as soon as the resource gets deleted, but in certain environment user may want to retain the images for subsequent runs because every time image import is a costly affair.

Proposing following field to the resource:

// IBMPowerVSImageSpec defines the desired state of IBMPowerVSImage
type IBMPowerVSImageSpec struct {

	// +kubebuilder:default=delete
	// +kubebuilder:validation:Enum=delete;retain
	// +optional
	DeletePolicy string `json:"deletePolicy,omitempty"`
        
}

If policy is set as retain then don't trigger the delete call to the backend

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Feb 5, 2022
@mkumatag mkumatag added this to the Next milestone Feb 5, 2022
@mkumatag
Copy link
Member Author

/assign @Prajyot-Parab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants