Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API key via kubernetes secret #402

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

mkumatag
Copy link
Member

What this PR does / why we need it:

This PR will help the user to supply the API key via k8s secret and the controller will use the API key via that secret to talk to the IBM Cloud.

Typical flow:

$ kustomize build config/default > infrastructure-components.yaml
# manually edit the file and replace the `${IBMCLOUD_API_KEY}` with a valid key
# this will be replaced on the fly when we use clusterctl init command in the future.
$ kubectl apply -f infrastructure-components.yaml

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes: #366

Special notes for your reviewer:

/area provider/ibmcloud

Release note:


@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 28, 2021
@mkumatag
Copy link
Member Author

/cc @wentao-zh

@k8s-ci-robot k8s-ci-robot requested review from gyliu513, jichenjc and wentao-zh and removed request for gyliu513 and jichenjc October 28, 2021 11:41
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2021
Copy link
Contributor

@wentao-zh wentao-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, wentao-zh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@wentao-zh wentao-zh removed their assignment Oct 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit bd57c70 into kubernetes-sigs:main Oct 29, 2021
@mkumatag mkumatag deleted the credentials branch October 29, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the code to use the API key from the secret
3 participants