Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the code to use the API key from the secret #366

Closed
2 tasks done
mkumatag opened this issue Oct 18, 2021 · 0 comments · Fixed by #402
Closed
2 tasks done

Enhance the code to use the API key from the secret #366

mkumatag opened this issue Oct 18, 2021 · 0 comments · Fixed by #402
Assignees
@mkumatag
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@mkumatag
Copy link
Member

mkumatag commented Oct 18, 2021 •
edited
Loading

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
Enhance the controller to use the API Key from the secret

  • Adopt the authenticator
  • Enhance the deployment yaml to read the API key from the secret
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Oct 18, 2021
@mkumatag mkumatag added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 18, 2021
@mkumatag mkumatag mentioned this issue Oct 28, 2021
Merged
@mkumatag mkumatag self-assigned this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkumatag mkumatag

Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API key via kubernetes secret mkumatag/cluster-api-provider-ibmcloud
2 participants
@mkumatag @k8s-ci-robot