Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uncached client #1682

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Use uncached client #1682

merged 1 commit into from
Mar 25, 2024

Conversation

Karthik-K-N
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1681

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 25, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 3cef581
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/660116de58f574000819fa4f
😎 Deploy Preview https://deploy-preview-1682--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mkumatag
mkumatag approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit aa44df2 into kubernetes-sigs:main Mar 25, 2024
13 checks passed
Karthik-K-N added a commit to Karthik-K-N/cluster-api-provider-ibmcloud that referenced this pull request Mar 26, 2024
@Karthik-K-N
Revert "Use uncached client (kubernetes-sigs#1682)"
93ae5a4 
This reverts commit aa44df2.
@Karthik-K-N Karthik-K-N mentioned this pull request Mar 27, 2024
Closed
Karthik-K-N added a commit to Karthik-K-N/cluster-api-provider-ibmcloud that referenced this pull request Mar 27, 2024
@Karthik-K-N
Revert "Use uncached client (kubernetes-sigs#1682)"
0ccbfe8 
This reverts commit aa44df2.
k8s-ci-robot pushed a commit that referenced this pull request Mar 27, 2024
@Karthik-K-N
Explicitly set GVK for IBMPoweVSCluster resource (#1692)
ff8b672 
* Revert "Use uncached client (#1682)"

This reverts commit aa44df2.

* Explicitly set GVK for IBMPowerVSCluster object
Karthik-K-N added a commit to Karthik-K-N/cluster-api-provider-ibmcloud that referenced this pull request Apr 5, 2024
@Karthik-K-N
Revert "Use uncached client (kubernetes-sigs#1682)"
232e33b 
This reverts commit aa44df2.
k8s-ci-robot pushed a commit that referenced this pull request Apr 8, 2024
@Karthik-K-N
Validate DHCP network id (#1714)
1cad73b 
* Revert "Use uncached client (#1682)"

This reverts commit aa44df2.

* Explicitly set GVK for IBMPowerVSCluster object

* Validate Network ID for nil before dereferencing
Karthik-K-N added a commit to Karthik-K-N/cluster-api-provider-ibmcloud that referenced this pull request Apr 16, 2024
@Karthik-K-N
Revert "Use uncached client (kubernetes-sigs#1682)"
b8579d3 
This reverts commit aa44df2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@Amulyam24 Amulyam24 Awaiting requested review from Amulyam24

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IBM Cloud resources are not being cleaned up during cluster destroy
3 participants
@Karthik-K-N @k8s-ci-robot @mkumatag