Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 combine AZURE_STANDARD_JSON_B64 and AZURE_VMSS_JSON_B64 into AZURE_JSON_B64 #753

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

chewong
Copy link
Member

@chewong chewong commented Jul 6, 2020

What this PR does / why we need it:

Address #746 (comment).

/assign @CecileRobertMichon
/test pull-cluster-api-provider-azure-capi-e2e
/test pull-cluster-api-provider-azure-conformance-v1alpha3
/test pull-cluster-api-provider-azure-conformance-machine-pool-v1alpha3

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider labels Jul 6, 2020
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 6, 2020
@nader-ziada
Copy link
Contributor

nader-ziada commented Jul 6, 2020

does that mean we can't use standard vmType?

@CecileRobertMichon
Copy link
Contributor

@nader-ziada we shouldn't need the standard vmType for Standard LB it works for both VMs and VMSS, see kubernetes-sigs/cloud-provider-azure#338 (comment) and #695

(of course a user could always modify the template to use the standard vmType if they really wanted to).

@nader-ziada
Copy link
Contributor

@nader-ziada we shouldn't need the standard vmType for Standard LB it works for both VMs and VMSS, see kubernetes-sigs/cloud-provider-azure#338 (comment) and #695

(of course a user could always modify the template to use the standard vmType if they really wanted to).

ok thanks for the explanation

@chewong
Copy link
Member Author

chewong commented Jul 6, 2020

/retest

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 033e7f9 into kubernetes-sigs:master Jul 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Jul 6, 2020
@chewong chewong deleted the azure-json-b64 branch July 6, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants