-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 combine AZURE_STANDARD_JSON_B64 and AZURE_VMSS_JSON_B64 into AZURE_JSON_B64 #753
Conversation
does that mean we can't use |
@nader-ziada we shouldn't need the standard vmType for Standard LB it works for both VMs and VMSS, see kubernetes-sigs/cloud-provider-azure#338 (comment) and #695 (of course a user could always modify the template to use the standard vmType if they really wanted to). |
ok thanks for the explanation |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Address #746 (comment).
/assign @CecileRobertMichon
/test pull-cluster-api-provider-azure-capi-e2e
/test pull-cluster-api-provider-azure-conformance-v1alpha3
/test pull-cluster-api-provider-azure-conformance-machine-pool-v1alpha3
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: