Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use vmType "vmss" in every template to allow mixed mode #695

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Jun 10, 2020

What this PR does / why we need it: Following conversation in kubernetes-sigs/cloud-provider-azure#338, this is to allow cloud-provider to be able to work with clusters that have both Machines and MachinePools (ie. VMAS and VMSS).

NAME                            STATUS   ROLES    AGE     VERSION
capz-control-plane-6rhzn   Ready    master   27m     v1.18.3
capz-control-plane-nvscv   Ready    master   20m     v1.18.3
capz-control-plane-qs6c8   Ready    master   25m     v1.18.3
capz-md-0-hftcw            Ready    <none>   25m     v1.18.3
capz-md-0-tdlds            Ready    <none>   25m     v1.18.3
capz-mp-0000000            Ready    <none>   6m13s   v1.18.3
capz-mp-0000002            Ready    <none>   6m13s   v1.18.3

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

:bug: Use vmType "vmss" in every template to allow clusters that have both Machines and MachinePools

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 10, 2020
@CecileRobertMichon
Copy link
Contributor Author

/hold
/assign @feiskyer

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2020
@CecileRobertMichon CecileRobertMichon changed the title 🐛 Use vmType "vmss" in every template to allow mixed mode 🐛 Use vmType "vmss" in every template to allow mixed mode Jun 10, 2020
@CecileRobertMichon
Copy link
Contributor Author

/retest
/hold cancel
Got confirmation from @feiskyer kubernetes-sigs/cloud-provider-azure#338 (comment)
/assign @devigned

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2020
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

So glad you were able to get clarity on this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit a7b849c into kubernetes-sigs:master Jun 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Jun 11, 2020
@CecileRobertMichon CecileRobertMichon deleted the vmss-vmtype branch July 9, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants