-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Spot VMs #559
Conversation
@JoelSpeed do you have plans to document this feature in the cluster API book or does it make sense to add a short doc in here for now? also FYI @devigned this is probably something we'll want to bring to the vmss implementation after both PRs merge or possibly in this one if #483 merges first. |
Opened #575 to track AzureMachinePool support separately. |
@CecileRobertMichon I was planning to have docs in the main CAPI book eventually, but not sure when that will be done. For now I'm happy to add a short doc in this PR which can be removed later once the full CAPI docs are done |
@JoelSpeed this still needs docs + a rebase when you get a chance |
@CecileRobertMichon Apologies for the delay! I have rebased and added a small doc, not sure how much is appropriate to write here, I can expand more if you would like |
@CecileRobertMichon Is there anything more you want me to do with this? Did we want to raise the question about the |
@JoelSpeed the only two things left for me are 1) merge kubernetes-sigs/cluster-api#3063 and 2) resolve the question on |
this looks good to me and ready to be merged, but asking @CecileRobertMichon if she has other comments since she has more context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @JoelSpeed 🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds a
spotVMOptions
field to the AzureMachineSpec to allow users to request a Spot VM rather than a standard on-demand VMWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #407 (Should 407 cover machinepool too?)
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: