Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Spot VMs #559

Merged
merged 5 commits into from
Jun 25, 2020
Merged

Conversation

JoelSpeed
Copy link
Contributor

What this PR does / why we need it:

Adds a spotVMOptions field to the AzureMachineSpec to allow users to request a Spot VM rather than a standard on-demand VM

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #407 (Should 407 cover machinepool too?)

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add support for Spot VMs to AzureMachine

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 21, 2020
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 21, 2020
@CecileRobertMichon
Copy link
Contributor

@JoelSpeed do you have plans to document this feature in the cluster API book or does it make sense to add a short doc in here for now?

also FYI @devigned this is probably something we'll want to bring to the vmss implementation after both PRs merge or possibly in this one if #483 merges first.

@CecileRobertMichon
Copy link
Contributor

Opened #575 to track AzureMachinePool support separately.

@JoelSpeed
Copy link
Contributor Author

@CecileRobertMichon I was planning to have docs in the main CAPI book eventually, but not sure when that will be done. For now I'm happy to add a short doc in this PR which can be removed later once the full CAPI docs are done

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2020
@CecileRobertMichon
Copy link
Contributor

@JoelSpeed this still needs docs + a rebase when you get a chance

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2020
@JoelSpeed
Copy link
Contributor Author

@CecileRobertMichon Apologies for the delay! I have rebased and added a small doc, not sure how much is appropriate to write here, I can expand more if you would like

docs/topics/spot-vms.md Outdated Show resolved Hide resolved
@JoelSpeed
Copy link
Contributor Author

@CecileRobertMichon Is there anything more you want me to do with this? Did we want to raise the question about the spotVMOptions: {} emptiness being the default usage? I don't mind it but if you think there's a potential to improve the UX then we should discuss

@CecileRobertMichon
Copy link
Contributor

@JoelSpeed the only two things left for me are 1) merge kubernetes-sigs/cluster-api#3063 and 2) resolve the question on spotVMOptions: {} usage. I'm not a big fan of having an empty "options" field to enable it but I've asked for second opinions on the thread above since this will likely affect CAPA as well.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2020
@nader-ziada
Copy link
Contributor

this looks good to me and ready to be merged, but asking @CecileRobertMichon if she has other comments since she has more context

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @JoelSpeed 🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4833e50 into kubernetes-sigs:master Jun 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Azure Spot VMs
6 participants