-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Spot instances support #1868
Conversation
Hi @alexander-demichev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-demichev Have you tested this in a live cluster?
Changes look to be identical to the openshift fork so should be good
/lgtm
Yes, tested on a real cluster, and yes it's similar to openshift |
Looks like the CRDs need to be regenerated
|
/ok-to-test |
/test pull-cluster-api-provider-aws-test |
/lgtm cancel |
@JoelSpeed done and CI works now |
/lgtm |
Great, thanks! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add a new field to API -
SpotMarketOptions
, then use it to create spot instance by initializing anInstanceMarketOptionsRequest
and passing it toRunInstances()
kubernetes-sigs/cluster-api-provider-azure#559
https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/proposals/20200330-spot-instances.md
Huge thanks to @JoelSpeed for making it possible!