Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Standard tier SKU for AKS e2e tests #4962

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jul 3, 2024

What type of PR is this?
/kind flake

What this PR does / why we need it:

This PR updates the CI templates to specify "Standard" tier AKS clusters instead of the default "Free" which was resulting in errors in some regions where AKS would fail to provision free clusters: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/directory/pull-cluster-api-provider-azure-e2e-aks/1803862127094534144

As a result, this PR adds back westeurope to the bucket of regions we use to test which was frequently hitting these kinds of errors.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4945

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 3, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 3, 2024

/cherry-pick release-1.15

@k8s-infra-cherrypick-robot

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 3, 2024

/assign @jackfrancis

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 3, 2024

/test pull-cluster-api-provider-azure-e2e-aks

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.25%. Comparing base (5493e53) to head (97869ed).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4962   +/-   ##
=======================================
  Coverage   62.25%   62.25%           
=======================================
  Files         201      201           
  Lines       16912    16912           
=======================================
  Hits        10529    10529           
  Misses       5590     5590           
  Partials      793      793           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73ce09ac501ccf54e2af72e8c370a338bfea4dd8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jackfrancis July 3, 2024 20:41
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 3, 2024

@jackfrancis I didn't get the schema right on the first try. Should be good now if you could please LGTM.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 3, 2024

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-with-wi-optional 97869ed link false /test pull-cluster-api-provider-azure-e2e-with-wi-optional

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jackfrancis
Copy link
Contributor

/test pull-cluster-api-provider-azure-conformance-custom-builds

@jackfrancis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 801f941e659146d5bdf85ac3c99a7f9d77ba2e83

@k8s-ci-robot k8s-ci-robot merged commit 81dd271 into kubernetes-sigs:main Jul 4, 2024
27 of 28 checks passed
@k8s-infra-cherrypick-robot

@nojnhuh: #4962 failed to apply on top of branch "release-1.15":

Applying: Use Standard tier SKU for AKS e2e tests
Using index info to reconstruct a base tree...
M	hack/util.sh
M	templates/test/ci/cluster-template-prow-aks-clusterclass.yaml
M	templates/test/ci/cluster-template-prow-aks.yaml
M	templates/test/ci/prow-aks-aso/kustomization.yaml
M	templates/test/ci/prow-aks-clusterclass/kustomization.yaml
M	templates/test/ci/prow-aks/kustomization.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/test/ci/prow-aks/kustomization.yaml
CONFLICT (content): Merge conflict in templates/test/ci/prow-aks/kustomization.yaml
Auto-merging templates/test/ci/prow-aks-clusterclass/kustomization.yaml
CONFLICT (content): Merge conflict in templates/test/ci/prow-aks-clusterclass/kustomization.yaml
Auto-merging templates/test/ci/prow-aks-aso/kustomization.yaml
CONFLICT (content): Merge conflict in templates/test/ci/prow-aks-aso/kustomization.yaml
Auto-merging templates/test/ci/cluster-template-prow-aks.yaml
Auto-merging templates/test/ci/cluster-template-prow-aks-clusterclass.yaml
Auto-merging hack/util.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use Standard tier SKU for AKS e2e tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add westeurope to e2e test regions
4 participants