-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Standard tier SKU for AKS e2e tests #4962
Conversation
/cherry-pick release-1.15 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @jackfrancis |
/test pull-cluster-api-provider-azure-e2e-aks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4962 +/- ##
=======================================
Coverage 62.25% 62.25%
=======================================
Files 201 201
Lines 16912 16912
=======================================
Hits 10529 10529
Misses 5590 5590
Partials 793 793 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 73ce09ac501ccf54e2af72e8c370a338bfea4dd8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jackfrancis I didn't get the schema right on the first try. Should be good now if you could please LGTM. |
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test pull-cluster-api-provider-azure-conformance-custom-builds |
/lgtm |
LGTM label has been added. Git tree hash: 801f941e659146d5bdf85ac3c99a7f9d77ba2e83
|
@nojnhuh: #4962 failed to apply on top of branch "release-1.15":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind flake
What this PR does / why we need it:
This PR updates the CI templates to specify "Standard" tier AKS clusters instead of the default "Free" which was resulting in errors in some regions where AKS would fail to provision free clusters: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/directory/pull-cluster-api-provider-azure-e2e-aks/1803862127094534144
As a result, this PR adds back
westeurope
to the bucket of regions we use to test which was frequently hitting these kinds of errors.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4945
Special notes for your reviewer:
TODOs:
Release note: