-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.14] use default k8s version for spot e2e test #4912
[release-1.14] use default k8s version for spot e2e test #4912
Conversation
It looks like there was some copy-pasta when this test was first made that locked it to the Flatcar test's k8s version which seems like a mistake. This PR removes that to fallback to the default to fix this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: ff69c78392424079a371e62f0c08ca25c7d3628d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.14 #4912 +/- ##
================================================
- Coverage 62.65% 62.64% -0.02%
================================================
Files 192 192
Lines 15694 15694
================================================
- Hits 9833 9831 -2
- Misses 5174 5176 +2
Partials 687 687 ☔ View full report in Codecov by Sentry. |
This is an automated cherry-pick of #4910
/assign nojnhuh