use default k8s version for spot e2e test #4910
Conversation
It looks like there was some copy-pasta when this test was first made that locked it to the Flatcar test's k8s version which seems like a mistake. This PR removes that to fallback to the default to fix this test.
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
|
/cherry-pick release-1.14 /test pull-cluster-api-provider-azure-e2e-optional |
|
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.15 |
|
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mboersma Is my assumption that the k8s v1.26.13 images are EOL correct based on this log message in the failing tests? |
|
@nojnhuh yes, (almost) all the v1.26.x images were deprecated on June 5th. But v1.26.15 will be available until August 17th, so if a test really can't update to a more current, supported version of Kubernetes, they can use v1.26.15 for another sixty or so days. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6844d71180ba3f57db67f274aff21db8f2370511
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4910 +/- ##
=======================================
Coverage 62.19% 62.19%
=======================================
Files 201 201
Lines 16878 16878
=======================================
Hits 10497 10497
Misses 5591 5591
Partials 790 790 ☔ View full report in Codecov by Sentry. |
|
/assign @willie-yao |
|
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Optional job failure is in the cluster class test so I'm reasonably confident that's a flake. The spot test passed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@nojnhuh: new pull request created: #4912 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nojnhuh: new pull request created: #4913 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
It looks like there was some copy-pasta when this test was first made that locked it to the Flatcar test's k8s version which seems like a mistake. This PR removes that to fallback to the default to fix this test.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: