ASOAPI: propagate machinepool values to ManagedClustersAgentPools #4798
Conversation
k8s-ci-robot
added
release-note-none
|
/hold for #4794 |
k8s-ci-robot
added
size/XXL
|
/milestone v1.15 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4798 +/- ##
==========================================
+ Coverage 62.66% 62.73% +0.06%
==========================================
Files 198 199 +1
Lines 16420 16507 +87
==========================================
+ Hits 10290 10356 +66
- Misses 5369 5381 +12
- Partials 761 770 +9 ☔ View full report in Codecov by Sentry. |
| } else if replicaManager != infrav1exp.ReplicasManagedByAKS { | ||
| return fmt.Errorf("failed to enable autoscaling, replicas are already being managed by %s according to MachinePool %s's %s annotation", replicaManager, machinePool.Name, clusterv1.ReplicasManagedByAnnotation) | ||
| } | ||
| } else if !autoscaling && replicaManager == infrav1exp.ReplicasManagedByAKS { |
There was a problem hiding this comment.
Can we add a comment here to indicate that this implements the required reconciliation logic to enable mutating from "node pool is autoscaler-enabled" to "node pool is not autoscaler-enabled"?
There was a problem hiding this comment.
Not sure I exactly get what you mean, but I took a stab here.
|
this lgtm w/ some minor comments |
|
/hold only for squash now that #4794 has merged. |
k8s-ci-robot
added
size/XL
It wasn't automatic, but merging main seemed to work so those old changes don't appear in the diff anymore. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1599f67ed609ef80db50dbf0f9e1a8ad53b3baca
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
squashed! (to the original two commits) |
k8s-ci-robot
removed
the
do-not-merge/hold
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR uses the ASOAPI mutator framework to set the Kubernetes version and replica count for ASO agent pools based on its owning MachinePool. It also includes handling for autoscaling AKS node pools.
The first commit in this PR is the same as what's queued up to merge in #4794. It should disappear from this PR automatically once that other PR merges. I'm electing to create this PR now to open up these new changes for feedback in the meantime.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #4713
Special notes for your reviewer:
TODOs:
Release note: