-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASOAPI: aggregate agentPoolProfiles for ManagedCluster create #4794
ASOAPI: aggregate agentPoolProfiles for ManagedCluster create #4794
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4794 +/- ##
==========================================
+ Coverage 62.62% 62.66% +0.04%
==========================================
Files 198 198
Lines 16285 16420 +135
==========================================
+ Hits 10198 10290 +92
- Misses 5341 5369 +28
- Partials 746 761 +15 ☔ View full report in Codecov by Sentry. |
/hold for squash |
return err | ||
} | ||
|
||
profile := asocontainerservicev1hub.ManagedClusterAgentPoolProfile{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much ongoing maintenance will this manual conversion take?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All we should need to do is add any new AKS API versions for each new ASO release to the scheme we create in main
. If the hub type happens to change between ASO releases, we should get a compiler error here. When that happens, we would need to update these fields to include any new fields in the new hub version.
If Azure/azure-service-operator#2791 gets resolved, then none of that should be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compiler error is the news I came to hear
/lgtm |
LGTM label has been added. Git tree hash: 43b590ca3623a0d5c9b74815dd83253b64b19d1d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6fa5fcc
to
6af0559
Compare
squashed! |
@nojnhuh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR leverages the mutator framework added in #4793 to aggregate the
spec.agentPoolProfiles
to be created alongside an ASO ManagedCluster to fulfill AKS's requirement that ManagedClusters must be created with at least one node pool. This is modeled after how CAPZ already handles this for AzureManagedControlPlanes.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #4713
Special notes for your reviewer:
TODOs:
Release note: