Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.13] use existing virtualNetwork from a different rg #4747

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[release-1.13] use existing virtualNetwork from a different rg #4747

merged 1 commit into from
Apr 18, 2024

Conversation

willie-yao
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
This is a manual cherry-pick of #4606

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

use existing virtualNetwork from a different rg

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 17, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 17, 2024
@willie-yao willie-yao changed the base branch from main to release-1.13 April 17, 2024 18:46
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 17, 2024
willie-yao
willie-yao commented Apr 17, 2024
View reviewed changes
azure/scope/managedcontrolplane.go
@@ -273,6 +273,15 @@ func (s *ManagedControlPlaneScope) GroupSpecs() []azure.ASOResourceSpecGetter[*a
Owner: *metav1.NewControllerRef(s.ControlPlane, infrav1.GroupVersion.WithKind(infrav1.AzureManagedControlPlaneKind)),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skipped out on adding the unit tests from GroupSpecs() here and in cluster.go due to the owner still being set in this version, and we can't test the owner being set correctly since it sets some fields to the address of a bool.

@willie-yao willie-yao force-pushed the use-existing-vnet-1.13 branch from d93727e to 93648b6 Compare April 17, 2024 18:53
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 62.08%. Comparing base (1183772) to head (93648b6).
Report is 3 commits behind head on release-1.13.

Files Patch % Lines
azure/scope/managedcontrolplane.go 0.00% 11 Missing ⚠️
azure/scope/cluster.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.13    #4747   +/-   ##
=============================================
  Coverage         62.07%   62.08%           
=============================================
  Files               189      189           
  Lines             14920    14954   +34     
=============================================
+ Hits               9262     9284   +22     
- Misses             5017     5029   +12     
  Partials            641      641

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 17, 2024 •
edited
Loading

@willie-yao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apidiff d93727e link false /test pull-cluster-api-provider-azure-apidiff
pull-cluster-api-provider-azure-verify d93727e link true /test pull-cluster-api-provider-azure-verify
pull-cluster-api-provider-azure-ci-entrypoint d93727e link true /test pull-cluster-api-provider-azure-ci-entrypoint
pull-cluster-api-provider-azure-build d93727e link true /test pull-cluster-api-provider-azure-build
pull-cluster-api-provider-azure-e2e-aks d93727e link true /test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-capi-e2e d93727e link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-conformance d93727e link false /test pull-cluster-api-provider-azure-conformance
pull-cluster-api-provider-azure-e2e d93727e link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-conformance-with-ci-artifacts d93727e link false /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts d93727e link false /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts d93727e link false /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
pull-cluster-api-provider-azure-windows-with-ci-artifacts d93727e link false /test pull-cluster-api-provider-azure-windows-with-ci-artifacts
pull-cluster-api-provider-azure-test d93727e link true /test pull-cluster-api-provider-azure-test
pull-cluster-api-provider-azure-apiversion-upgrade d93727e link false /test pull-cluster-api-provider-azure-apiversion-upgrade
pull-cluster-api-provider-azure-windows-custom-builds d93727e link false /test pull-cluster-api-provider-azure-windows-custom-builds
pull-cluster-api-provider-azure-conformance-custom-builds d93727e link false /test pull-cluster-api-provider-azure-conformance-custom-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@willie-yao
Copy link
Contributor Author

/retest

mboersma
mboersma approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 03fd004693cf2ea8fcc730672af4ddfde3be6883

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit d850054 into kubernetes-sigs:release-1.13 Apr 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willie-yao @k8s-ci-robot @mboersma