use existing virtualNetwork from a different rg

[nawazkh]

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR will enable using existing virtualNetwork from a different rg.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4595

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

use existing virtualNetwork from a different rg 

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[nawazkh]

/cc @kubernetes-sigs/cluster-api-provider-azure-pms

[nawazkh]

/retest

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.71%. Comparing base (9724fc0) to head (7c5df96).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4606      +/-   ##
==========================================
+ Coverage   62.47%   62.71%   +0.23%     
==========================================
  Files         192      192              
  Lines       15453    15487      +34     
==========================================
+ Hits         9655     9713      +58     
+ Misses       5131     5107      -24     
  Partials      667      667              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: aca2741938b9e39dac96f2050d2d01a40f1483f4

[willie-yao]

/lgtm

[nojnhuh]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nojnhuh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jackfrancis]

@willie-yao @nojnhuh could you investigate if the approach here could potentially solve for #4704

[jackfrancis]

... and maybe #4699

[willie-yao]

... and maybe #4699

@jackfrancis I don't think this approach will work because the error message is coming from k8s itself regarding the metadata.name field, so I'm not sure if this is even possible.

https://github.com/kubernetes/kubernetes/blob/9791f0d1f39f3f1e0796add7833c1059325d5098/staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go#L205

[jackfrancis]

@nojnhuh @willie-yao @mboersma can we get a consensus vote on whether or not to classify this as a bug? Was the BYO VNET story always meant (and documented) to support a VNET from a different resource group than the cluster resource group? If so, I think this is a bug fix and can be backported.

Thoughts?

[willie-yao]

I'd say it counts as a bug since it fixes something that used to work before a certain version and I'm in favor of the backport.

[nojnhuh]

I think this is fair to backport.

[mboersma]

Yes, this seems worthy of backporting.

/cherrypick release-1.14
/cherrypick release-1.13

[k8s-infra-cherrypick-robot]

@mboersma: #4606 failed to apply on top of branch "release-1.14":

Applying: check vnets for azure managed control plane and
Using index info to reconstruct a base tree...
M	api/v1beta1/azuremanagedcontrolplane_webhook.go
M	api/v1beta1/azuremanagedcontrolplane_webhook_test.go
M	api/v1beta1/azuremanagedcontrolplanetemplate_webhook.go
M	azure/defaults.go
M	azure/defaults_test.go
M	azure/scope/cluster.go
M	azure/scope/cluster_test.go
M	azure/scope/managedcontrolplane.go
M	azure/scope/managedcontrolplane_test.go
M	azure/services/groups/spec.go
M	azure/services/groups/spec_test.go
Falling back to patching base and 3-way merge...
Auto-merging azure/scope/managedcontrolplane_test.go
CONFLICT (content): Merge conflict in azure/scope/managedcontrolplane_test.go
Auto-merging azure/scope/managedcontrolplane.go
Auto-merging api/v1beta1/azuremanagedcontrolplane_webhook_test.go
Auto-merging api/v1beta1/azuremanagedcontrolplane_webhook.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 check vnets for azure managed control plane and
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Yes, this seems worthy of backporting.

/cherrypick release-1.14
/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[willie-yao]

@mboersma I can help manually backport this!

[willie-yao]

/cherrypick release-1.13

[willie-yao]

Oh wait I got confused. This commit is already in release-1.14 😆

[k8s-infra-cherrypick-robot]

@willie-yao: #4606 failed to apply on top of branch "release-1.13":

Applying: check vnets for azure managed control plane and
Using index info to reconstruct a base tree...
M	api/v1beta1/azuremanagedcontrolplane_webhook.go
M	api/v1beta1/azuremanagedcontrolplane_webhook_test.go
M	api/v1beta1/azuremanagedcontrolplanetemplate_webhook.go
M	azure/scope/cluster.go
M	azure/scope/cluster_test.go
M	azure/scope/managedcontrolplane.go
M	azure/scope/managedcontrolplane_test.go
M	azure/services/groups/spec.go
M	azure/services/groups/spec_test.go
Falling back to patching base and 3-way merge...
Auto-merging azure/services/groups/spec_test.go
Auto-merging azure/services/groups/spec.go
CONFLICT (content): Merge conflict in azure/services/groups/spec.go
Auto-merging azure/scope/managedcontrolplane_test.go
CONFLICT (content): Merge conflict in azure/scope/managedcontrolplane_test.go
Auto-merging azure/scope/managedcontrolplane.go
CONFLICT (content): Merge conflict in azure/scope/managedcontrolplane.go
Auto-merging azure/scope/cluster_test.go
Auto-merging azure/scope/cluster.go
CONFLICT (content): Merge conflict in azure/scope/cluster.go
Auto-merging api/v1beta1/azuremanagedcontrolplanetemplate_webhook.go
CONFLICT (content): Merge conflict in api/v1beta1/azuremanagedcontrolplanetemplate_webhook.go
Auto-merging api/v1beta1/azuremanagedcontrolplane_webhook_test.go
CONFLICT (content): Merge conflict in api/v1beta1/azuremanagedcontrolplane_webhook_test.go
Auto-merging api/v1beta1/azuremanagedcontrolplane_webhook.go
CONFLICT (content): Merge conflict in api/v1beta1/azuremanagedcontrolplane_webhook.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 check vnets for azure managed control plane and
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.