Allow setting ResourceGroupName in AzureManagedControlPlaneTemplate #4723
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/M
willie-yao
force-pushed
the
amcp-rg-name
branch
from
e05f726 to
a4ff476
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4723 +/- ##
==========================================
+ Coverage 62.00% 62.02% +0.01%
==========================================
Files 201 201
Lines 16857 16857
==========================================
+ Hits 10453 10456 +3
+ Misses 5620 5618 -2
+ Partials 784 783 -1 ☔ View full report in Codecov by Sentry. |
| @@ -139,10 +139,6 @@ const ( | |||
| type AzureManagedControlPlaneSpec struct { | |||
| AzureManagedControlPlaneClassSpec `json:",inline"` | |||
|
|
|||
| // ResourceGroupName is the name of the Azure resource group for this AKS Cluster. | |||
| // Immutable. | |||
| ResourceGroupName string `json:"resourceGroupName"` | |||
There was a problem hiding this comment.
Is this not API-breaking?
There was a problem hiding this comment.
It's similar to #4735 where it technically breaks the Go API by moving the field to the template type, but it wont break any user-facing scenarios. Nothing is removed from the CRD itself https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4723/files#diff-bab27b20a078754613e88030b4d2e38ba01555267143727b7f6718c10018cecd
|
/test ls |
|
@jackfrancis: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-provider-azure-e2e-workload-upgrade |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d426f818f35c7a242f0459be25d273526c0bde7c
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
CI thinks we need to run |
|
/retest |
k8s-ci-robot
removed
the
lgtm
|
@willie-yao: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: cb23af07ac69279c91c1d91e8069711b3ce26f12
|
|
/test pull-cluster-api-provider-azure-verify Something funky going on with CI... |
|
/test pull-cluster-api-provider-azure-build |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR allows setting ResourceGroupName in AzureManagedControlPlaneTemplate type instead of just in the non-template type.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4721
Special notes for your reviewer:
TODOs:
Release note: