Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting ResourceGroupName in AzureManagedControlPlaneTemplate #4721

Closed
MagnusRef opened this issue Apr 11, 2024 · 2 comments · Fixed by #4723
Closed

Allow setting ResourceGroupName in AzureManagedControlPlaneTemplate #4721

MagnusRef opened this issue Apr 11, 2024 · 2 comments · Fixed by #4723
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/proposal Issues or PRs related to proposals.

Comments

@MagnusRef
Copy link
Contributor

⚠️ Cluster API Azure maintainers can ask to turn an issue-proposal into a CAEP when necessary. This is to be expected for large changes that impact multiple components, breaking changes, or new large features.

Goals

  1. To be able to specify the resource group name of a AzureManagedControlPlaneTemplate just like in AzureManagedControlPlane.

Non-Goals/Future Work

  1. N/A

User Story

As an operator I would like to be able name the resource group for the AKS cluster based on something else than the metadate.name of the cluster object.

Detailed Description

In my case I would like to name the resourcegroup the same as the metadata.controlPlaneRef.name of my cluster object, just like how it automatically picks up the controlplane name in self-managed kubeadm clusters in CAPZ.

This would from an operator point of view be done with JSON patching in the ClusterClass, if ResourceGroupName was exposed in the AzureManagedControlPlaneTemplate.

The reason for doing this is to not get into situations where multiple controlplanes gets deployed to the same resource group. This can happend if you have multiple management clusters, or loss of cluster state in a management cluster.

This Issue was made based on a this convosation on the cluster-api-azure slack channel:
https://kubernetes.slack.com/archives/CEX9HENG7/p1712320334762489

With information gathered from: #2684

Thank you!

Contract changes [optional]

Not sure

Data model changes [optional]

Not sure

/kind proposal

@k8s-ci-robot k8s-ci-robot added the kind/proposal Issues or PRs related to proposals. label Apr 11, 2024
@willie-yao
Copy link
Contributor

/assign

@willie-yao
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/proposal Issues or PRs related to proposals.
Projects
Archived in project
3 participants