-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update AzCNI to new installer image #4315
Conversation
@rbtr: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @rbtr! |
Hi @rbtr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4315 +/- ##
==========================================
+ Coverage 60.03% 60.45% +0.41%
==========================================
Files 192 191 -1
Lines 19297 19195 -102
==========================================
+ Hits 11585 11604 +19
+ Misses 7075 6947 -128
- Partials 637 644 +7 ☔ View full report in Codecov by Sentry. |
/retest @rbtr the Azure CNI e2e test failed, PTAL |
waiting on Azure/azure-container-networking#2417 then will bump this again to resolve |
9f8eeb1
to
e0967c6
Compare
|
Signed-off-by: Evan Baker <[email protected]>
e0967c6
to
6f3cc09
Compare
/retest |
/kind cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I wish y`all had copied it, then there only would have been one thing to update 🥲
Is this still an approach we should take in CAPZ? If so, let's open an issue with more specific detail.
LGTM label has been added. Git tree hash: 77e42193155243dfcdc253aaf69471a88c4366e7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it: Migrates to new installer image for AzCNI. Incidentally upgrades the AzCNI version.
See Azure/azure-container-networking#2333
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: