Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update AzCNI to new installer image #4315

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Nov 27, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it: Migrates to new installer image for AzCNI. Incidentally upgrades the AzCNI version.

See Azure/azure-container-networking#2333

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

Release note:

Update AzCNI to v1.5.16

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

@rbtr: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind chore

What this PR does / why we need it: Migrates to new installer image for AzCNI. Incidentally upgrades the AzCNI version.

See Azure/azure-container-networking#2333

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update AzCNI to v1.5.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @rbtr!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @rbtr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (388398e) 60.03% compared to head (6f3cc09) 60.45%.
Report is 74 commits behind head on main.

Files Patch % Lines
exp/controllers/helpers.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4315      +/-   ##
==========================================
+ Coverage   60.03%   60.45%   +0.41%     
==========================================
  Files         192      191       -1     
  Lines       19297    19195     -102     
==========================================
+ Hits        11585    11604      +19     
+ Misses       7075     6947     -128     
- Partials      637      644       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CecileRobertMichon
Copy link
Contributor

/retest

@rbtr the Azure CNI e2e test failed, PTAL

@rbtr
Copy link
Contributor Author

rbtr commented Nov 28, 2023

waiting on Azure/azure-container-networking#2417 then will bump this again to resolve

@rbtr rbtr force-pushed the chore/update-azcni-v1 branch from 9f8eeb1 to e0967c6 Compare November 28, 2023 20:34
@rbtr
Copy link
Contributor Author

rbtr commented Nov 28, 2023

updated actually needs a newer image tagged and published with an unreleased fix, will update again

@rbtr rbtr marked this pull request as draft November 29, 2023 16:30
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2023
@rbtr rbtr force-pushed the chore/update-azcni-v1 branch from e0967c6 to 6f3cc09 Compare December 7, 2023 22:43
@rbtr
Copy link
Contributor Author

rbtr commented Dec 7, 2023

/retest

@rbtr rbtr marked this pull request as ready for review December 7, 2023 22:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2023
@rbtr
Copy link
Contributor Author

rbtr commented Dec 8, 2023

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 8, 2023
@rbtr rbtr requested a review from mboersma December 12, 2023 15:14
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I wish y`all had copied it, then there only would have been one thing to update 🥲

Is this still an approach we should take in CAPZ? If so, let's open an issue with more specific detail.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 77e42193155243dfcdc253aaf69471a88c4366e7

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit d38a314 into kubernetes-sigs:main Dec 12, 2023
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants