Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNI Installer migration #2333

Closed
14 tasks done
rbtr opened this issue Oct 27, 2023 · 2 comments · Fixed by #2324
Closed
14 tasks done

CNI Installer migration #2333

rbtr opened this issue Oct 27, 2023 · 2 comments · Fixed by #2324
Assignees
@rbtr
Labels
azure-ipam cni Related to CNI. dropgz dropgz enhancement exempt-stale Keep this fresh needs-backport Change needs to be backported to previous release trains release/latest Change affects latest release train release/1.4 Change affects v1.4 release train work-in-progress

Comments

@rbtr
Copy link
Contributor

rbtr commented Oct 27, 2023 •
edited
Loading

This is a tracking issue for the work to migrate from the single dropgz image to per-component -installer images.

Up until now, we have released the CNI installer image (cni-dropgz) as a versioned component separately from the CNI releases themselves. This has created a bit of versioning hell, as we struggle to maintain multiple release trains of the CNI (and thus CNI installer) and azure-ipam when the CNI/azure-ipam and installer version are not correlated.

The proposed change is to flip the architecture of the CNI installer: treat dropgz as a library, and leverage it to build separate installer images for each versioned component which we need to install via container.

We will migrate from the current state of:

image binaries version
cni-dropgz a.b.c
azure-vnet j.k.l
azure-ipam x.y.z

to

image binaries version
cni-installer j.k.l
azure-vnet j.k.l
ipam-installer x.y.z
azure-ipam x.y.z

Migration steps:
@rbtr rbtr self-assigned this Oct 27, 2023
@rbtr rbtr added enhancement cni Related to CNI. azure-ipam release/1.4 Change affects v1.4 release train release/latest Change affects latest release train needs-backport Change needs to be backported to previous release trains dropgz dropgz work-in-progress labels Oct 27, 2023
@rbtr rbtr linked a pull request Oct 27, 2023 that will close this issue
feat: build cni installer image with cni builds #2324
Merged
10 tasks
@rbtr rbtr mentioned this issue Oct 27, 2023
Merged
10 tasks
@rbtr rbtr reopened this Oct 30, 2023
@rbtr rbtr mentioned this issue Oct 30, 2023
Merged
4 tasks
@rbtr rbtr mentioned this issue Nov 9, 2023
Merged
4 tasks
This was referenced Nov 22, 2023
Closed
Merged
@rbtr rbtr mentioned this issue Dec 7, 2023
Merged
4 tasks
@github-actions github-actions bot added the stale Stale due to inactivity. label Dec 20, 2023
@Azure Azure deleted a comment from github-actions bot Dec 20, 2023
@rbtr rbtr removed the stale Stale due to inactivity. label Dec 20, 2023
@github-actions github-actions bot added the stale Stale due to inactivity. label Jan 4, 2024
@Azure Azure deleted a comment from github-actions bot Jan 4, 2024
@rbtr rbtr added exempt-stale Keep this fresh and removed stale Stale due to inactivity. labels Jan 4, 2024
@rbtr rbtr mentioned this issue Apr 10, 2024
Merged
4 tasks
@rbtr rbtr mentioned this issue Jul 22, 2024
Merged
4 tasks
@rbtr
Copy link
Contributor Author

rbtr commented Sep 26, 2024

this is done for 1.5+, and can be closed as completed once #2871 is completed and AKS migrates for k8s 1.27.

@rbtr
Copy link
Contributor Author

rbtr commented Nov 19, 2024

AKS has migrated and cni-dropgz is unused. Purging it from the VHD here and closing this as complete 🎉

@rbtr rbtr closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbtr rbtr

Labels
azure-ipam cni Related to CNI. dropgz dropgz enhancement exempt-stale Keep this fresh needs-backport Change needs to be backported to previous release trains release/latest Change affects latest release train release/1.4 Change affects v1.4 release train work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: build cni installer image with cni builds Azure/azure-container-networking
1 participant
@rbtr