feat: build cni installer image with cni builds #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
added
enhancement
cni
rbtr
force-pushed
the
fix/dropgz-cni-versions
branch
from
265bef4 to
7d10576
Compare
rbtr
force-pushed
the
fix/dropgz-cni-versions
branch
from
7d10576 to
96fc870
Compare
rbtr
force-pushed
the
fix/dropgz-cni-versions
branch
3 times, most recently
from
59fde34 to
27a0712
Compare
|
Just a qq, what does "omnibus" mean in this context? Sounds cool "Previously, dropgz pulled in the released CNI tarballs as dependencies and produced a "dropgz-vX" omnibus image which contained uncorrelated CNI versions" |
pjohnst5
reviewed
Oct 27, 2023
pjohnst5
reviewed
Oct 27, 2023
vipul-21
reviewed
Oct 27, 2023
camrynl
reviewed
Oct 27, 2023
camrynl
reviewed
Oct 27, 2023
14 tasks
rbtr
force-pushed
the
fix/dropgz-cni-versions
branch
from
27a0712 to
37a7d96
Compare
rbtr
force-pushed
the
fix/dropgz-cni-versions
branch
2 times, most recently
from
c4e808b to
07797dd
Compare
|
@camrynl @vipul-21 @pjohnst5 |
camrynl
approved these changes
Oct 27, 2023
rbtr
force-pushed
the
fix/dropgz-cni-versions
branch
from
07797dd to
99fb8ff
Compare
What is the expected impact from using older infra as this migration happens? |
jpayne3506
reviewed
Oct 27, 2023
| @@ -159,6 +159,20 @@ stages: | |||
| name: "$(BUILD_POOL_NAME_LINUX_AMD64)" | |||
| strategy: | |||
| matrix: | |||
| cni_linux_amd64: | |||
There was a problem hiding this comment.
Unless this gets renamed back to cni-dropgz, which from the PR description it is indicating that it will be,
Instead of deploying a "dropgz:v0.0.4" with unknown (at least, non-obvious) CNI payload versions, we produce a "cni-dropgz:v1.5.11"
we need to add this to the cleanup script regex for acnpublic
rbtr
force-pushed
the
fix/dropgz-cni-versions
branch
from
99fb8ff to
cb45f49
Compare
nddq
force-pushed
the
fix/dropgz-cni-versions
branch
from
cb45f49 to
02d1fbc
Compare
Signed-off-by: Evan Baker <[email protected]>
rbtr
force-pushed
the
fix/dropgz-cni-versions
branch
from
02d1fbc to
3ea0176
Compare
jpayne3506
approved these changes
Oct 30, 2023
rbtr
added a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 26, 2024
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 30, 2024
feat: rip out dropgz (#2324) (#2339) Signed-off-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Up until now, we have released the CNI installer image as a separately versioned component from the CNI releases themselves. This has created a bit of versioning hell, as we struggle to maintain multiple release trains of the CNI (and thus CNI installer) when the CNI and installer version are not correlated.
This change flips the CNI installer image builder architecture. Previously,
dropgzpulled in the released CNI tarballs as dependencies and produced a "dropgz-vX" omnibus image which contained uncorrelated CNI versions.Here, we migrate instead to a CNI Dockerfile which imports
dropgzas the dependency and is built in lockstep with (at least) azure-vnet builds, and versioned the same as them. Instead of deploying a "dropgz:v0.0.4" with unknown (at least, non-obvious) CNI payload versions, we produce a "cni-installer:v1.5.11" during the CNI release process with no ambiguity.This is part 1 of this migration:
Issue Fixed:
Requirements:
Notes: