Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jaeger all-in-one chart to v0.1.11 #4055

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Sep 29, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the Jaeger all-in-one Helm chart to v0.1.11. This updates Jaeger to a recent version that supports otlp input, since the jaeger exporter itself was removed in opentelemetry 1.18.

Which issue(s) this PR fixes:

Refs #4004

Special notes for your reviewer:

This is only relevant to the Tilt developer environment. I've tested it manually and traces in Jaeger seem fine.

This update was created by changing the Chart version in ./hack/observability/jaeger/fetch-jaeger-resources.sh and running that script.

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 29, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (42115ba) 56.65% compared to head (2c2b4cb) 56.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4055   +/-   ##
=======================================
  Coverage   56.65%   56.65%           
=======================================
  Files         187      187           
  Lines       19143    19143           
=======================================
  Hits        10846    10846           
  Misses       7668     7668           
  Partials      629      629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm traces also seem fine to me with these changes. Thank you @mboersma!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 65dc9257ab5428c00545d8067c78e43f06aed228

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 65cc88e into kubernetes-sigs:main Sep 29, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 29, 2023
@mboersma mboersma deleted the update-jaeger branch September 29, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants