-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jaeger all-in-one chart to v0.1.11 #4055
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4055 +/- ##
=======================================
Coverage 56.65% 56.65%
=======================================
Files 187 187
Lines 19143 19143
=======================================
Hits 10846 10846
Misses 7668 7668
Partials 629 629 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm traces also seem fine to me with these changes. Thank you @mboersma!
/lgtm
LGTM label has been added. Git tree hash: 65dc9257ab5428c00545d8067c78e43f06aed228
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates the Jaeger all-in-one Helm chart to v0.1.11. This updates Jaeger to a recent version that supports
otlp
input, since thejaeger
exporter itself was removed in opentelemetry 1.18.Which issue(s) this PR fixes:
Refs #4004
Special notes for your reviewer:
This is only relevant to the Tilt developer environment. I've tested it manually and traces in Jaeger seem fine.
This update was created by changing the Chart version in
./hack/observability/jaeger/fetch-jaeger-resources.sh
and running that script.TODOs:
Release note: