-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependabot(deps): bump go.opentelemetry.io/otel from 1.17.0 to 1.19.0 #4004
dependabot(deps): bump go.opentelemetry.io/otel from 1.17.0 to 1.19.0 #4004
Conversation
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold This needs updating in some correlated modules. I'll do that soon. |
This |
436706d
to
531df60
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4004 +/- ##
=======================================
Coverage 56.66% 56.66%
=======================================
Files 187 187
Lines 19143 19143
=======================================
Hits 10848 10848
Misses 7666 7666
Partials 629 629 ☔ View full report in Codecov by Sentry. |
There is apparently a way to have Jaeger consume |
/milestone v1.12 We've learned it's painful to fall too far behind opentelemetry releases. |
531df60
to
e2e88ac
Compare
After updating the jaeger-all-in-one chart in #4055, this just required some reconfiguration to use I verified locally in |
/hold cancel |
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.17.0 to 1.19.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.17.0...v1.19.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
e2e88ac
to
6b33f79
Compare
/retitle dependabot(deps): bump go.opentelemetry.io/otel from 1.17.0 to 1.19.0 Updated to include the even fresher otel v1.19.0 release (and to keep dependabot from creating a new PR on Monday). Also retested in tilt. |
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0 | ||
go.opentelemetry.io/otel/exporters/prometheus v0.42.0 | ||
go.opentelemetry.io/otel/sdk v1.19.0 | ||
go.opentelemetry.io/otel/sdk/metric v1.19.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opentelemetry metrics are considered a stable API as of the v1.19.0 release. 👍🏻
A newer version of go.opentelemetry.io/otel exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
/lgtm++ |
Could someone give this a review when time permits? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 68f23d026aab2de7a70a2b3a8520fd5d9893278b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bumps go.opentelemetry.io/otel from 1.17.0 to 1.18.0.
Changelog
Sourced from go.opentelemetry.io/otel's changelog.
Commits
4242228
Release v1.18.0/v0.41.0/v0.0.6 (#4489)ac4fca2
Use a TB interface in metricdatatest (#4483)77d6237
Bump actions/checkout from 3 to 4 (#4490)8ef7339
dependabot updates Sun Sep 10 14:30:56 UTC 2023 (#4498)e44ea5c
Revert "Collector example: add metrics and use official port (#4466)" (#4487)9737995
Drop support for Go 1.19 (#4481)6eedabf
Collector example: add metrics and use official port (#4466)76c370f
Document public metric SDK interfaces to remain stable (#4396)01d64c3
Update go versions used in workflows (#4480)fc70923
Ignore value option for metricdatatest (#4447)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)