Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot(deps): bump go.opentelemetry.io/otel from 1.17.0 to 1.19.0 #4004

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 18, 2023

Bumps go.opentelemetry.io/otel from 1.17.0 to 1.18.0.

Changelog

Sourced from go.opentelemetry.io/otel's changelog.

[1.18.0/0.41.0/0.0.6] 2023-09-12

This release drops the compatibility guarantee of [Go 1.19].

Added

  • Add WithProducer option in go.opentelemetry.op/otel/exporters/prometheus to restore the ability to register producers on the prometheus exporter's manual reader. (#4473)
  • Add IgnoreValue option in go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest to allow ignoring values when comparing metrics. (#4447)

Changed

  • Use a TestingT interface instead of *testing.T struct in go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest. (#4483)

Deprecated

  • The NewMetricExporter in go.opentelemetry.io/otel/bridge/opencensus was deprecated in v0.35.0 (#3541). The deprecation notice format for the function has been corrected to trigger Go documentation and build tooling. (#4470)

Removed

  • Removed the deprecated go.opentelemetry.io/otel/exporters/jaeger package. (#4467)
  • Removed the deprecated go.opentelemetry.io/otel/example/jaeger package. (#4467)
  • Removed the deprecated go.opentelemetry.io/otel/sdk/metric/aggregation package. (#4468)
  • Removed the deprecated internal packages in go.opentelemetry.io/otel/exporters/otlp and its sub-packages. (#4469)
  • Dropped guaranteed support for versions of Go less than 1.20. (#4481)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 18, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2023
@mboersma
Copy link
Contributor

/hold

This needs updating in some correlated modules. I'll do that soon.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
@mboersma
Copy link
Contributor

This otel release actually drops support entirely for the Jaeger exporter, which we use in the Tilt environment. App Insights should still work, but we should investigate if there's another local trace exporter we could use.

@dependabot dependabot bot force-pushed the dependabot/go_modules/go.opentelemetry.io/otel-1.18.0 branch from 436706d to 531df60 Compare September 19, 2023 18:43
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cd1421d) 56.66% compared to head (6b33f79) 56.66%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4004   +/-   ##
=======================================
  Coverage   56.66%   56.66%           
=======================================
  Files         187      187           
  Lines       19143    19143           
=======================================
  Hits        10848    10848           
  Misses       7666     7666           
  Partials      629      629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor

There is apparently a way to have Jaeger consume oltp (or oltphttp?) directly now, so the jaeger exporter is no longer needed, but Jaeger is still supported. I'll try to reconfigure things so traces keep working and update this PR.

@mboersma
Copy link
Contributor

/milestone v1.12

We've learned it's painful to fall too far behind opentelemetry releases.

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 21, 2023
@mboersma mboersma force-pushed the dependabot/go_modules/go.opentelemetry.io/otel-1.18.0 branch from 531df60 to e2e88ac Compare September 29, 2023 18:23
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2023
@mboersma
Copy link
Contributor

After updating the jaeger-all-in-one chart in #4055, this just required some reconfiguration to use otlphttp for traces to Jaeger and some testing.

I verified locally in tilt that metrics to Prometheus and traces to Jaeger and App Insights are working with this change.

@mboersma
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2023
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.17.0 to 1.19.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.17.0...v1.19.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@mboersma mboersma force-pushed the dependabot/go_modules/go.opentelemetry.io/otel-1.18.0 branch from e2e88ac to 6b33f79 Compare September 29, 2023 18:48
@mboersma
Copy link
Contributor

mboersma commented Sep 29, 2023

/retitle dependabot(deps): bump go.opentelemetry.io/otel from 1.17.0 to 1.19.0

Updated to include the even fresher otel v1.19.0 release (and to keep dependabot from creating a new PR on Monday). Also retested in tilt.

@k8s-ci-robot k8s-ci-robot changed the title dependabot(deps): bump go.opentelemetry.io/otel from 1.17.0 to 1.18.0 dependabot(deps): bump go.opentelemetry.io/otel from 1.17.0 to 1.19.0 Sep 29, 2023
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0
go.opentelemetry.io/otel/exporters/prometheus v0.42.0
go.opentelemetry.io/otel/sdk v1.19.0
go.opentelemetry.io/otel/sdk/metric v1.19.0
Copy link
Contributor

@mboersma mboersma Sep 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opentelemetry metrics are considered a stable API as of the v1.19.0 release. 👍🏻

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 2, 2023

A newer version of go.opentelemetry.io/otel exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@mboersma
Copy link
Contributor

mboersma commented Oct 2, 2023

/cc @CecileRobertMichon @nojnhuh

@nawazkh
Copy link
Member

nawazkh commented Oct 2, 2023

/lgtm++

@mboersma
Copy link
Contributor

mboersma commented Oct 3, 2023

Could someone give this a review when time permits? otel 1.20.0 is already out.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 68f23d026aab2de7a70a2b3a8520fd5d9893278b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 03e441b into main Oct 3, 2023
11 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/go.opentelemetry.io/otel-1.18.0 branch October 3, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants