-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.10] Bump CAPI to v1.4.5 #3782
[release-1.10] Bump CAPI to v1.4.5 #3782
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #3782 +/- ##
=============================================
Coverage 54.05% 54.05%
=============================================
Files 186 186
Lines 18833 18833
=============================================
Hits 10181 10181
Misses 8105 8105
Partials 547 547 ☔ View full report in Codecov by Sentry. |
@mboersma the test failure looks like a Helm install error is there any way to make the output for those more human readable? |
We print all the output from the
I'm not positive we're actually retrying successfully here though... The code is written with Gingko |
@k8s-infra-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Yes, now I see the actual output in the test output and I agree it's clear enough. I was originally looking at the ginkgo summary which isn't as readable...
And yes it doesn't seem like this was a transient network flake that we should have retried and didn't. |
@mboersma Was this retrying in the main branch when we merged it? In other words, did we ever encounter an error and need to loop until the install succeeds? |
I thought so, but I'm not sure now. 🤷🏻 I'll make a test PR with a bad Helm chart and see if I can work it out there. (Meanwhile, we need CAPI v1.4.5 to merge in both release branches so testgrid stops being red for multiple SIG projects. We tried to work around the bug by reverting the Go compiler, but it's whack-a-mole and that was a temporary band-aid anyway.) /retest |
I created #3787 and I'm investigating why it's not retrying. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 1e784519a8a6c56a9b94a1a361a9e58a226307b3
|
This is an automated cherry-pick of #3756
/assign mboersma