Bump CAPI to v1.4.5

[mboersma]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI references to use the new v1.4.5 release.

Which issue(s) this PR fixes:

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Update CAPI to v1.4.5

[CecileRobertMichon]

/retest

looks like a flake...

[CecileRobertMichon]

I believe we also need to update https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/azure/scope/managedcontrolplane.go#L607 for AKS

This may also apply to the azurejson secrets

cluster-api-provider-azure/controllers/helpers.go

Line 179 in 687e66f

secret := &corev1.Secret{

see https://github.com/kubernetes-sigs/cluster-api/pull/9080/files#

[mboersma]

@CecileRobertMichon that's just for CAPI v1.5, right, not v1.4.5? I'll make those changes in #3707.

[CecileRobertMichon]

@CecileRobertMichon that's just for CAPI v1.5, right, not v1.4.5? I'll make those changes in #3707.

yep you're totally right, I commented on the wrong PR 🤦‍♀️

[mboersma]

/hold

I rebased this on #3757, which needs to merge first.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b67082) 54.36% compared to head (35e14e4) 54.36%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3756   +/-   ##
=======================================
  Coverage   54.36%   54.36%           
=======================================
  Files         187      187           
  Lines       18998    18998           
=======================================
  Hits        10328    10328           
  Misses       8113     8113           
  Partials      557      557           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mboersma]

/hold cancel

[CecileRobertMichon]

/lgtm
/assign @nojnhuh

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: add4463a4130d9526287e295f3510fa8177c1660

[nojnhuh]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nojnhuh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

/cherry-pick release-1.10

[k8s-infra-cherrypick-robot]

@mboersma: new pull request created: #3782

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mboersma]

/cherry-pick release-1.9

[k8s-infra-cherrypick-robot]

@mboersma: #3756 failed to apply on top of branch "release-1.9":

Applying: Bump CAPI to v1.4.5
Using index info to reconstruct a base tree...
M	Makefile
M	Tiltfile
M	go.mod
M	go.sum
M	test/e2e/config/azure-dev.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/config/azure-dev.yaml
CONFLICT (content): Merge conflict in test/e2e/config/azure-dev.yaml
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging Tiltfile
CONFLICT (content): Merge conflict in Tiltfile
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump CAPI to v1.4.5
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.