Allow azure:// prefix when parsing resource IDs #3616
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
size/XS
|
This is a quick fix for that specific issue. Alternately, I could write a wrapper function around |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3616 +/- ##
==========================================
- Coverage 53.52% 53.26% -0.27%
==========================================
Files 185 185
Lines 18544 18435 -109
==========================================
- Hits 9926 9819 -107
+ Misses 8076 8074 -2
Partials 542 542
☔ View full report in Codecov by Sentry. |
mboersma
force-pushed
the
fix-user-assigned-id-format
branch
from
179864f to
0daf1b0
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6896872a150392f365c0870432894b224b6b3259
|
More changes incoming, including webhook validation and unit tests. Sorry for the thrashing, should have been a [WIP]. Edit: actually, I think I'll leave the webhook changes for a subsequent PR. See #3618. |
mboersma
force-pushed
the
fix-user-assigned-id-format
branch
from
d61ff8a to
6dfe2f0
Compare
|
/retitle Allow azure:// prefix when parsing resource IDs |
k8s-ci-robot
changed the title
|
/cherry-pick release-1.9 |
|
@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
approved
|
/override codecov/patch This change is being penalized for three changed lines of code that were previously not unit tested. I looked at each one, and it's not trivial to write a test harness around those funcs, so I think it's out of scope for this PR to add that. I entered an issue to add unit test coverage: #3622. |
|
@mboersma: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I'm confused; I thought we had configured prow so codecov was informational, not blocking. Yet prow is saying it won't merge because codecov has not succeeded. |
|
@mboersma we had, however @willie-yao recently got the k8s GitHub admins to add the codecov app to the CAPZ repo, I wonder if that is what caused a change Edit: probably, we have both |
|
Can we do " |
|
/override tide |
|
@mboersma: Overrode contexts on behalf of mboersma: tide In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override codecov/patch |
|
@CecileRobertMichon: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mboersma
force-pushed
the
fix-user-assigned-id-format
branch
from
6dfe2f0 to
38e0c03
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5b09606fd88448983e556e175338821fbafa1cfc
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mboersma: new pull request created: #3626 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Handles user-assigned identity resource identifiers starting with an
azure://prefix, which the newParseResourceID()func doesn't tolerate.Which issue(s) this PR fixes:
Fixes #3597
Special notes for your reviewer:
TODOs:
Release note: