-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CAPI to v1.4.3 #3612
Update CAPI to v1.4.3 #3612
Conversation
ebbeb7a
to
2c982d3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3612 +/- ##
==========================================
- Coverage 53.58% 53.21% -0.37%
==========================================
Files 185 185
Lines 18552 18431 -121
==========================================
- Hits 9941 9808 -133
- Misses 8069 8081 +12
Partials 542 542
☔ View full report in Codecov by Sentry. |
f043321
to
70174fa
Compare
70174fa
to
947cf35
Compare
36d25ba
to
69dad47
Compare
/hold Let's rebase this after #3616 merges, so it doesn't duplicate code. |
69dad47
to
8538e3d
Compare
/hold cancel |
@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8538e3d
to
5ac35ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 5c938112c57a7f5a0fc20ac6d9914d8f20715de3
|
/milestone v1.10 |
5ac35ee
to
2864560
Compare
/retest pull-cluster-api-provider-azure-e2e
|
/test pull-cluster-api-provider-azure-e2e |
/lgtm |
LGTM label has been added. Git tree hash: 4141d180d8709f86c0d441a443f5e8b6593c0df2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mboersma: #3612 failed to apply on top of branch "release-1.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates CAPI references to use the v1.4.3 release. Also bumps cert-manager to v1.12.1 to match CAPI. Reimplements some trivial string processing methods that were deprecated in CAPI.
Which issue(s) this PR fixes:
Closes #3613
Special notes for your reviewer:
TODOs:
Release note: