-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.8] update golang to v1.20 #3496
[release-1.8] update golang to v1.20 #3496
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Have all test-infra jobs (in k/k, provider-azure, SIG Windows, CAPZ, etc) that build CAPZ from source using release-1.8 been updated to use the latest kubekins image with go 1.20? |
@CecileRobertMichon kubekins audit below:
So, according to this we aren't going to be able to use CAPZ @ go1.20 for jobs that use kubekins < v1.27: Do we want to consider pointing older release branch jobs that use kubekins < 1.27 to CAPZ @ release-1.7? The only other near-term way to unblock cloud-provider-azure would be to point its jobs to CAPZ @ main, which I don't think we want to do. PS @feiskyer @lzhecheng do we want to update the |
@jackfrancis Yes, I think we can use master kubekins image. |
/lgtm cancel @jackfrancis should we close this PR? See also kubernetes/test-infra#29431 |
@mboersma yes! |
This is a manual cherry-pick of #3478
/assign CecileRobertMichon