Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.8] update golang to v1.20 #3496

Conversation

jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Apr 28, 2023

This is a manual cherry-pick of #3478

/assign CecileRobertMichon

use golang v1.20 to build and test CAPZ

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 28, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jackfrancis. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 28, 2023
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2023
@CecileRobertMichon
Copy link
Contributor

Have all test-infra jobs (in k/k, provider-azure, SIG Windows, CAPZ, etc) that build CAPZ from source using release-1.8 been updated to use the latest kubekins image with go 1.20?

@jackfrancis
Copy link
Contributor Author

@CecileRobertMichon kubekins audit below:

  • CAPZ test jobs are using v1.27 (which is go1.20): update CAPZ kubekins to 1.27 kubernetes/test-infra#29355
  • k/k presubmit cloud-provider-azure jobs are using v1.27
  • cloud-provider-azure jobs are using the master kubekins build (which is go1.20)
    • except the following jobs:
      • pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-25 is using gcr.io/k8s-staging-test-infra/kubekins-e2e:v20230406-23cb1879e3-1.25
      • pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-26 is using gcr.io/k8s-staging-test-infra/kubekins-e2e:v20230406-23cb1879e3-1.26
      • pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-27 is using gcr.io/k8s-staging-test-infra/kubekins-e2e:v20230406-23cb1879e3-1.27
  • CSI jobs are using v1.27
  • sig-windows tests against master are using the master kubekins build
  • sig-windows jobs against k/k release branches are using the same-versioned kubekins image as the release branch

So, according to this we aren't going to be able to use CAPZ @ go1.20 for jobs that use kubekins < v1.27:

Do we want to consider pointing older release branch jobs that use kubekins < 1.27 to CAPZ @ release-1.7? The only other near-term way to unblock cloud-provider-azure would be to point its jobs to CAPZ @ main, which I don't think we want to do.

PS @feiskyer @lzhecheng do we want to update the pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-25, pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-26, and pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-27 jobs so that they use the master kubekins images like their peer jobs? Was that just an oversight?

@lzhecheng
Copy link
Contributor

lzhecheng commented May 4, 2023

@jackfrancis Yes, I think we can use master kubekins image.
kubernetes/test-infra#29418

@mboersma
Copy link
Contributor

mboersma commented May 5, 2023

/lgtm cancel

@jackfrancis should we close this PR?

See also kubernetes/test-infra#29431

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2023
@k8s-ci-robot k8s-ci-robot requested a review from mboersma May 5, 2023 16:54
@jackfrancis
Copy link
Contributor Author

@mboersma yes!

@jackfrancis jackfrancis closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants