update golang to v1.20

[jackfrancis]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates golang to v1.20 to match CAPI:

• 🌱Upgrade golang version (1.19.6 -> 1.20.3) cluster-api#8527

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

use golang v1.20 to build and test CAPZ

[jackfrancis]

/test ls

[k8s-ci-robot]

@jackfrancis: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-azure-build
• /test pull-cluster-api-provider-azure-ci-entrypoint
• /test pull-cluster-api-provider-azure-e2e
• /test pull-cluster-api-provider-azure-e2e-aks
• /test pull-cluster-api-provider-azure-test
• /test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-azure-apidiff
• /test pull-cluster-api-provider-azure-apiversion-upgrade
• /test pull-cluster-api-provider-azure-capi-e2e
• /test pull-cluster-api-provider-azure-conformance
• /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
• /test pull-cluster-api-provider-azure-e2e-optional
• /test pull-cluster-api-provider-azure-e2e-workload-upgrade
• /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
• /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-azure-apidiff
• pull-cluster-api-provider-azure-build
• pull-cluster-api-provider-azure-capi-e2e
• pull-cluster-api-provider-azure-ci-entrypoint
• pull-cluster-api-provider-azure-conformance
• pull-cluster-api-provider-azure-conformance-with-ci-artifacts
• pull-cluster-api-provider-azure-e2e
• pull-cluster-api-provider-azure-e2e-aks
• pull-cluster-api-provider-azure-test
• pull-cluster-api-provider-azure-verify
• pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jackfrancis]

/test pull-cluster-api-provider-azure-apidiff
/test pull-cluster-api-provider-azure-apiversion-upgrade
/test pull-cluster-api-provider-azure-e2e-optional
/test pull-cluster-api-provider-azure-e2e-workload-upgrade
/test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow

[Jont828]

Looking good so far, do you know if there's anything we'll need to refactor? Or do we expect this to be fully backward compatible?

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b084e15) 52.51% compared to head (2908f13) 52.51%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3478   +/-   ##
=======================================
  Coverage   52.51%   52.51%           
=======================================
  Files         182      182           
  Lines       18175    18176    +1     
=======================================
+ Hits         9545     9546    +1     
  Misses       8090     8090           
  Partials      540      540           

Impacted Files	Coverage Δ
...ool_deployments/machinepool_deployment_strategy.go	84.11% <100.00%> (+0.09%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jackfrancis]

/test pull-cluster-api-provider-azure-apidiff
/test pull-cluster-api-provider-azure-apiversion-upgrade
/test pull-cluster-api-provider-azure-e2e-optional
/test pull-cluster-api-provider-azure-e2e-workload-upgrade
/test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow

[jackfrancis]

@Jont828 I'm relying upon tests to tell us whether or not this is a breaking change. So far I've overcome a (IMO) spurious linter error for math/rand, but that's it.

[jackfrancis]

/retest

[jackfrancis]

/retest

[jackfrancis]

@marosset @jsturtevant how important is it to get positive signal from the "serial-slow" test, is the fidelity of that signal poor in your experiences?

[mboersma]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 5c463f11c5e7dac59829dc424e9f4592042cff9a

[lzhecheng]

@jackfrancis may I ask how is the PR going? Our CI pipeline needs golang 1.20 to build images. Thanks a lot!

[jackfrancis]

/retest

[jackfrancis]

@lzhecheng I've been waiting for a positive signal from the pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow test, it's re-running now...

[k8s-ci-robot]

@jackfrancis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow	2908f13	link	false	/test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jackfrancis]

@marosset @jsturtevant @CecileRobertMichon I don't think any of the "serial-slow" conformance test case failures have anything to do with the fact that we're using golang v1.20 to compile the CAPZ bits.

Does anyone disagree? Anything else we want to validate before we consider for merge?

[jsturtevant]

Yes, The failures are due to a bug with HPA tests upstream and cause a timeout in the test. The main set of tests are passing with pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts

/lgtm

[jsturtevant]

this is the upstream pr that will resolve the hpa tests: kubernetes/kubernetes#117192

[jackfrancis]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jackfrancis]

/cherry-pick release-1.8

@CecileRobertMichon @mboersma normally this wouldn't qualify for a patch, right? but in order to unblock cloud-provider-azure I believe we're going to need the release-1.8 branch to build from go1.20

[k8s-infra-cherrypick-robot]

@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

@CecileRobertMichon @mboersma normally this wouldn't qualify for a patch, right? but in order to unblock cloud-provider-azure I believe we're going to need the release-1.8 branch to build from go1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@jackfrancis: #3478 failed to apply on top of branch "release-1.8":

Applying: update golang to v1.20
Using index info to reconstruct a base tree...
M	.github/workflows/cover.yaml
M	.github/workflows/dependabot-code-gen.yml
M	.github/workflows/release.yaml
A	.github/workflows/scan.yml
M	.golangci.yml
M	Makefile
M	Tiltfile
M	docs/book/src/developers/development.md
M	go.mod
M	hack/tools/go.mod
Falling back to patching base and 3-way merge...
Auto-merging hack/tools/go.mod
Auto-merging go.mod
Auto-merging docs/book/src/developers/development.md
Auto-merging Tiltfile
Auto-merging Makefile
Auto-merging .golangci.yml
CONFLICT (modify/delete): .github/workflows/scan.yml deleted in HEAD and modified in update golang to v1.20. Version update golang to v1.20 of .github/workflows/scan.yml left in tree.
Auto-merging .github/workflows/release.yaml
Auto-merging .github/workflows/dependabot-code-gen.yml
Auto-merging .github/workflows/cover.yaml
CONFLICT (content): Merge conflict in .github/workflows/cover.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update golang to v1.20
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.8

@CecileRobertMichon @mboersma normally this wouldn't qualify for a patch, right? but in order to unblock cloud-provider-azure I believe we're going to need the release-1.8 branch to build from go1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.