Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to golangci-lint v1.44.2 #2148

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

Prajyot-Parab
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab commented Mar 4, 2022

Signed-off-by: Prajyot-Parab [email protected]

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • upgrade to golangci-lint v1.44.2
  • Fix related issues
exp/controllers/azuremanagedmachinepool_reconciler_test.go:39:71: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
                        Err:      errors.Wrap(NewAgentPoolVMSSNotFoundError("foo", "baz"), "boom!"),
                                                                                           ^
azure/services/loadbalancers/client.go:88:111: response body must be closed (bodyclose)
                err = autorest.NewErrorWithError(err, "network.LoadBalancersClient", "CreateOrUpdate", createFuture.Response(), "Failure sending request")

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2144

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Upgrade to golangci-lint v1.44.2

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2022
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 4, 2022
@Prajyot-Parab
Copy link
Contributor Author

/cc @sbueringer

@k8s-ci-robot k8s-ci-robot requested a review from sbueringer March 4, 2022 11:25
@sbueringer
Copy link
Member

I'll leave the review for the CAPZ folks as I'm not really familiar with CAPZ.

@mboersma
Copy link
Contributor

mboersma commented Mar 4, 2022

@Prajyot-Parab, looks like you need to run make generate and commit the changes it makes. (You can run make verify locally to ensure that it is passing.)

Edit: never mind, it's a general problem. Once #2147 merges, you can rebase from the main branch and it should be fine. Sorry about that!

@CecileRobertMichon
Copy link
Contributor

make verify is broken on main since last night because of #2147, should be unrelated to this PR. Will report back once we merge an update.

@CecileRobertMichon
Copy link
Contributor

/retest

@CecileRobertMichon
Copy link
Contributor

@mboersma this should be good now

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2022
@CecileRobertMichon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 37dfc68 into kubernetes-sigs:main Mar 4, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to golangci-lint v1.44.2
5 participants