Merge pull request #2148 from Prajyot-Parab/update

upgrade to golangci-lint v1.44.2
kubernetes-sigs · Mar 4, 2022 · 37dfc68 · 37dfc68
2 parents 6e96172 + a2d1cef
commit 37dfc68
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -76,7 +76,7 @@ ENVSUBST_VER := v2.0.0-20210730161058-179042472c46
 ENVSUBST_BIN := envsubst
 ENVSUBST := $(TOOLS_BIN_DIR)/$(ENVSUBST_BIN)-$(ENVSUBST_VER)
 
-GOLANGCI_LINT_VER := v1.43.0
+GOLANGCI_LINT_VER := v1.44.2
 GOLANGCI_LINT_BIN := golangci-lint
 GOLANGCI_LINT := $(TOOLS_BIN_DIR)/$(GOLANGCI_LINT_BIN)-$(GOLANGCI_LINT_VER)
 

diff --git a/azure/services/loadbalancers/client.go b/azure/services/loadbalancers/client.go
@@ -85,7 +85,10 @@ func (ac *azureClient) CreateOrUpdateAsync(ctx context.Context, spec azure.Resou
 
 	createFuture, err := ac.loadbalancers.CreateOrUpdateSender(req)
 	if err != nil {
-		err = autorest.NewErrorWithError(err, "network.LoadBalancersClient", "CreateOrUpdate", createFuture.Response(), "Failure sending request")
+		res := createFuture.Response()
+		err = autorest.NewErrorWithError(err, "network.LoadBalancersClient", "CreateOrUpdate", res, "Failure sending request")
+		// response body must be closed
+		res.Body.Close()
 		return nil, nil, err
 	}
 

diff --git a/exp/controllers/azuremanagedmachinepool_reconciler_test.go b/exp/controllers/azuremanagedmachinepool_reconciler_test.go
@@ -36,7 +36,7 @@ func TestIsAgentPoolVMSSNotFoundError(t *testing.T) {
 		},
 		{
 			Name:     "WithAWrappedNotFoundError",
-			Err:      errors.Wrap(NewAgentPoolVMSSNotFoundError("foo", "baz"), "boom!"),
+			Err:      errors.Wrap(NewAgentPoolVMSSNotFoundError("foo", "baz"), "boom"),
 			Expected: true,
 		},
 		{