[WIP] Don't call CreateOrUpdateZone if the zone already exists

[mboersma]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Since we don't allow changes to a private dns zone, we shouldn't be calling CreateOrUpdateZone on a zone that already exists. See #1791 (comment).

Which issue(s) this PR fixes:

Fixes #1872

Special notes for your reviewer:

cc: @sonasingh46, let me know if this is what you had in mind.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[mboersma]

/assign @shysank

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from shysank after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-coverage	91ec3ae	link	false	/test pull-cluster-api-provider-azure-coverage
pull-cluster-api-provider-azure-test	91ec3ae	link	true	/test pull-cluster-api-provider-azure-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sonasingh46]

@mboersma -- Yes. At that time, I was not aware about async framework. AFAIK, the async framework inherently fixes this. But for that we have to move to async framework for this one.
@shysank opened up a PR for to make the privatedns async changes.
Ref: #2007

[mboersma]

/close

Awesome, thanks for the clues. 😄

Closing in favor of #2007, which should also fix #1872.

[k8s-ci-robot]

@mboersma: Closed this PR.

In response to this:

/close

Awesome, thanks for the clues. 😄

Closing in favor of #2007, which should also fix #1872.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.