Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(private_dns): tag dns zone and delete only if owned #1791

Merged
merged 1 commit into from
Dec 13, 2021
Merged

chore(private_dns): tag dns zone and delete only if owned #1791

merged 1 commit into from
Dec 13, 2021

Conversation

sonasingh46
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR tags private DNS zone created by CAPZ and delete
only if it has been created by CAPZ.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1749

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

None

Signed-off-by: Ashutosh Kumar [email protected]

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @sonasingh46. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2021
@sonasingh46 sonasingh46 changed the title [WIP]chore(private_dns): tag dns zone and delete only if owned chore(private_dns): tag dns zone and delete only if owned Nov 12, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2021
CecileRobertMichon
CecileRobertMichon reviewed Nov 12, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2021
@sonasingh46 sonasingh46 force-pushed the byo_dns branch 2 times, most recently from dc67e82 to 87aa0f8 Compare November 13, 2021 20:34
shysank
shysank reviewed Nov 15, 2021
View reviewed changes
azure/services/privatedns/client.go Outdated Show resolved Hide resolved
azure/services/privatedns/client.go Outdated Show resolved Hide resolved
azure/services/privatedns/privatedns.go Outdated Show resolved Hide resolved
azure/services/privatedns/privatedns.go Outdated Show resolved Hide resolved
azure/services/privatedns/client.go Outdated Show resolved Hide resolved
azure/services/privatedns/privatedns.go Show resolved Hide resolved
@CecileRobertMichon CecileRobertMichon mentioned this pull request Nov 15, 2021
Closed
@sonasingh46 sonasingh46 mentioned this pull request Nov 17, 2021
Closed
@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Nov 24, 2021 •
edited
Loading

https://capz.sigs.k8s.io/topics/custom-dns.html (https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/docs/book/src/topics/custom-dns.md) would be a good place to document the feature

@sonasingh46 sonasingh46 force-pushed the byo_dns branch 2 times, most recently from 2979b8c to 4f82fdf Compare December 1, 2021 07:02
@CecileRobertMichon
Copy link
Contributor

@sonasingh46 please squash commits

@sonasingh46
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2021
@CecileRobertMichon
Copy link
Contributor

@sonasingh46 can you please rebase when you get a chance?

@sonasingh46
chore(private_dns): tag dns zone and delete only if owned
d060583 
This commit tags private DNS zone created by CAPZ and delete
only if it has been created by CAPZ

Signed-off-by: Ashutosh Kumar <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2021
@sonasingh46
Copy link
Contributor Author

@CecileRobertMichon -- Done rebase.

CecileRobertMichon
CecileRobertMichon reviewed Dec 13, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 92dcd55 into kubernetes-sigs:main Dec 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Dec 13, 2021
@sonasingh46 sonasingh46 mentioned this pull request Jan 25, 2022
Closed
7 tasks
@shysank shysank mentioned this pull request Feb 7, 2022
Merged
3 tasks
@mboersma mboersma mentioned this pull request Feb 8, 2022
Closed
3 tasks
@dthorsen dthorsen mentioned this pull request Jul 13, 2023
Closed
4 tasks
@mboersma mboersma mentioned this pull request Aug 10, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shysank shysank shysank left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@devigned devigned Awaiting requested review from devigned

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

BYO DNS Zone
5 participants
@sonasingh46 @k8s-ci-robot @CecileRobertMichon @devigned @shysank