Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CAPI to v0.4.3 #1750

Closed

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Oct 1, 2021

What type of PR is this?:

/kind other

What this PR does / why we need it:

Cherry-pick of #1728 to the release-0.5 branch.

See https://github.com/kubernetes-sigs/cluster-api/releases/tag/v0.4.3

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 1, 2021
@k8s-ci-robot
Copy link
Contributor

@mboersma: The label(s) kind/other cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?:

/kind other

What this PR does / why we need it:

Cherry-pick of #1728 to the release-0.5 branch.

See https://github.com/kubernetes-sigs/cluster-api/releases/tag/v0.4.3

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fabriziopandini after the PR has been reviewed.
You can assign the PR to them by writing /assign @fabriziopandini in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Oct 1, 2021
@CecileRobertMichon
Copy link
Contributor

/hold

why do we need to backport?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2021
@mboersma
Copy link
Contributor Author

mboersma commented Oct 4, 2021

why do we need to backport?

I thought we wanted this and #1751 in an upcoming v0.5.3 release... I figured it was a cherry-pick situation, but if I'm mistaken, please close them. :-)

@CecileRobertMichon
Copy link
Contributor

/close

I'm fast forwarding release-0.5 to the tip of the main branch as part of releasing

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closed this PR.

In response to this:

/close

I'm fast forwarding release-0.5 to the tip of the main branch as part of releasing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma mboersma deleted the capi-0.4.3-release-0.5 branch October 4, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants