Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CAPI to v0.4.3 #1728

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Update CAPI to v0.4.3 #1728

merged 2 commits into from
Sep 28, 2021

Conversation

CecileRobertMichon
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it: https://github.com/kubernetes-sigs/cluster-api/releases/tag/v0.4.3

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Sep 23, 2021
@CecileRobertMichon
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-capi-e2e

@CecileRobertMichon
Copy link
Contributor Author

/retest

@mboersma
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e

@mboersma
Copy link
Contributor

/test pull-cluster-api-provider-azure-test

@CecileRobertMichon
Copy link
Contributor Author

looks like cluster pause/unpause tests are failing

this is the second failure in a row, I think this is an actual failure

@mboersma
Copy link
Contributor

/test pull-cluster-api-provider-azure-coverage

CecileRobertMichon
CecileRobertMichon commented Sep 24, 2021
View reviewed changes
internal/test/logentries/pause_events.go
@@ -48,7 +48,7 @@ func GenerateCreateNotPausedLogEntries(ec EntryCriteria) []gomega.LogMatcher {
ec.ClusterName,
"msg",
"Cluster is not paused, allowing further processing",
).WithLevel(4).WithLogFunc("Info")
).WithLevel(6).WithLogFunc("Info")
Copy link
Contributor Author

@CecileRobertMichon CecileRobertMichon Sep 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see kubernetes-sigs/cluster-api@cf76954

@CecileRobertMichon
Copy link
Contributor Author

/retest

@CecileRobertMichon
Copy link
Contributor Author

/assign @mboersma @shysank

@CecileRobertMichon
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-capi-e2e
/retest

mboersma
mboersma approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2021
@shysank
Copy link
Contributor

shysank commented Sep 27, 2021

/test pull-cluster-api-provider-azure-e2e-exp

@shysank
Copy link
Contributor

shysank commented Sep 27, 2021

/test pull-cluster-api-provider-azure-capi-e2e

@CecileRobertMichon
Copy link
Contributor Author

/approve

@CecileRobertMichon
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2021
@CecileRobertMichon
Copy link
Contributor Author

the same test failed again with what seems to be connection timeout to the apiserver. The same test seems stable on main: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-periodic-capi-e2e-main

trying again in case we got unlucky twice

/retest

@shysank
Copy link
Contributor

shysank commented Sep 28, 2021 •
edited
Loading

seeing consistent errors when deleting resource group https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/1728/pull-cluster-api-provider-azure-capi-e2e/1442612992054136832/artifacts/clusters/bootstrap/controllers/capz-controller-manager/capz-controller-manager-67bfdf96f9-9txc2/manager.log
I0927 22:30:08.668572 1 async.go:54] controllers/AzureCluster "msg"="long running operation is still ongoing" "azureCluster"="kcp-upgrade-uuotly" "cluster"="kcp-upgrade-uuotly" "namespace"="kcp-upgrade-p5dswv" "resource"="capz-e2e-ohyn9d" "service"="group" I0927 22:30:08.669021 1 recorder.go:104] events "msg"="Warning" "message"="error deleting AzureCluster kcp-upgrade-p5dswv/kcp-upgrade-uuotly: failed to delete resource group: transient reconcile error occurred: operation type DELETE on Azure resource capz-e2e-ohyn9d/capz-e2e-ohyn9d is not done. Object will be requeued after 15s" "object"={"kind":"AzureCluster","namespace":"kcp-upgrade-p5dswv","name":"kcp-upgrade-uuotly","uid":"2fa8c4c7-acfb-4091-9c05-3f568920085b","apiVersion":"infrastructure.cluster.x-k8s.io/v1alpha4","resourceVersion":"8638"} "reason"="ClusterReconcilerDeleteFailed" I0927 22:30:08.669304 1 recorder.go:104] events "msg"="Warning" "message"="error deleting AzureCluster kcp-upgrade-p5dswv/kcp-upgrade-uuotly: failed to delete resource group: transient reconcile error occurred: operation type DELETE on Azure resource capz-e2e-ohyn9d/capz-e2e-ohyn9d is not done. Object will be requeued after 15s" "object"={"kind":"AzureCluster","namespace":"kcp-upgrade-p5dswv","name":"kcp-upgrade-uuotly","uid":"2fa8c4c7-acfb-4091-9c05-3f568920085b","apiVersion":"infrastructure.cluster.x-k8s.io/v1alpha4","resourceVersion":"8638"} "reason"="ClusterReconcilerDeleteFailed" E0927 22:30:08.700059 1 controller.go:304] controller/azurecluster "msg"="Reconciler error" "error"="error deleting AzureCluster kcp-upgrade-p5dswv/kcp-upgrade-uuotly: failed to delete resource group: transient reconcile error occurred: operation type DELETE on Azure resource capz-e2e-ohyn9d/capz-e2e-ohyn9d is not done. Object will be requeued after 15s" "name"="kcp-upgrade-uuotly" "namespace"="kcp-upgrade-p5dswv" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="AzureCluster" I0927 22:30:08.732544 1 azurecluster_controller.go:249] controllers/AzureCluster "msg"="Reconciling AzureCluster delete" "azureCluster"="kcp-upgrade-uuotly" "cluster"="kcp-upgrade-uuotly" "namespace"="kcp-upgrade-p5dswv"

@CecileRobertMichon
Copy link
Contributor Author

The log above is expected, it just means the RG was not done deleting yet (it takes a while). The real error on that test was

Message: "admission webhook "validation.kubeadmcontrolplane.controlplane.cluster.x-k8s.io" denied the request: KubeadmControlPlane.controlplane.cluster.x-k8s.io "kcp-upgrade-uuotly-control-plane" is invalid: spec.kubeadmConfigSpec.clusterConfiguration.etcd.local.dataDir: Forbidden: cannot be modified",

which is different from the MHC error we got previously.

/retest

@CecileRobertMichon
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit e532729 into kubernetes-sigs:main Sep 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Sep 28, 2021
@mboersma mboersma mentioned this pull request Oct 1, 2021
Closed
3 tasks
@CecileRobertMichon CecileRobertMichon deleted the capi-0.4.3 branch February 17, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@mboersma mboersma

@shysank shysank

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@CecileRobertMichon @mboersma @shysank @k8s-ci-robot