Cleanup disks service

[shysank]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Cleanup disks service

• Make Client interface private ( the methods are still exported to generate mocks)
• Move DiskScope and Service struct to disks.go
• NewService() -> New()
• Remove redundant initialization code in disks_test.go

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1001 (Partially)

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Cleanup disks service

[k8s-ci-robot]

Hi @shysank. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CecileRobertMichon]

/ok-to-test

[nader-ziada]

I like the approach 👍

[shysank]

API Diff

sigs.k8s.io/cluster-api-provider-azure/cloud/services/disks/mock_disks
  Incompatible changes:
  - MockClient: removed
  - MockClientMockRecorder: removed
  - NewMockClient: removed
  Compatible changes:
  - Mockclient: added
  - MockclientMockRecorder: added
  - NewMockclient: added
sigs.k8s.io/cluster-api-provider-azure/cloud/services/disks
  Incompatible changes:
  - AzureClient: removed
  - Client: removed
  - NewClient: removed
  - NewService: removed
  - Service.Client: removed
  Compatible changes:
  - New: added

[nader-ziada]

@devigned what do you think?

[devigned]

It's beautiful!

I left one super small nit. Thank you and great work!

[k8s-ci-robot]

@shysank: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-provider-azure-apidiff	ee66de2	link	/test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[CecileRobertMichon]

lgtm

[devigned]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devigned

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [devigned]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment