Make disks delete async

[Jont828]

What type of PR is this?

/kind feature
What this PR does / why we need it: Implementation of an async service for disks as a follow up for #1610 and #1541.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1711

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Make disks delete async

[k8s-ci-robot]

Hi @Jont828. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CecileRobertMichon]

/ok-to-test

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Jonathan Tong (dd31469, e96e496, 4ad6586, 7f41d50)

[Jont828]

@CecileRobertMichon Do you think it would make sense to add UpdatePutStatus(infrav1.DisksReadyCondition, serviceName, err) to the reconciler for async VMs? Since the reconciler for disks is a no-op we could try to update the status in the code that's responsible for creating the disks.

[Jont828]

/retest

[CecileRobertMichon]

@Jont828 please squash commits

[Jont828]

/retest

[CecileRobertMichon]

lgtm besides two minor comments

[Jont828]

/retest

[Jont828]

/retest

[Jont828]

/retest

[CecileRobertMichon]

/lgtm
/approve
/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CecileRobertMichon]

possibly a flake?

/retest

[Jont828]

/retest

[CecileRobertMichon]

/test pull-cluster-api-provider-azure-e2e

the test is going to fail, restarting to gain time. Going to look into the different failures.

[CecileRobertMichon]

/retest

quota issues on the sub should be mitigated

[CecileRobertMichon]

the latest one wasn't a quota issue, going to investigate separately (seems unrelated to this PR)

/retest

[Jont828]

/retest

[CecileRobertMichon]

this PR does not want to merge...

Issues we've run into so far:

• Context deadline exceeded on RG GET #1901
• quota issues (resolved)
• control planes not creating/joining (looking)
• service curl flakes

/retest

[k8s-ci-robot]

@Jont828: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-apidiff	4c58842	link	false	/test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.