Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] E2E standup tests #484

Closed
wants to merge 2 commits into from
Closed

Conversation

liztio
Copy link
Contributor

@liztio liztio commented Jan 9, 2019

What this PR does / why we need it:

Adds tests what will eventually be PR blocking. They should stand up a kubernetes cluster on AWS and test that the cluster works.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #271

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liztio
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: roberthbailey

If they are not already assigned, you can assign the PR to them by writing /assign @roberthbailey in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@liztio: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cluster-api-provider-aws-bazel-verify 756fec3 link /test pull-cluster-api-provider-aws-bazel-verify
pull-cluster-api-provider-aws-bazel-test 756fec3 link /test pull-cluster-api-provider-aws-bazel-test
pull-cluster-api-provider-aws-bazel-e2e 756fec3 link /test pull-cluster-api-provider-aws-bazel-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liztio liztio mentioned this pull request Feb 13, 2019
@randomvariable
Copy link
Member

@liztio, can this be closed?

@chuckha
Copy link
Contributor

chuckha commented Feb 19, 2019

/close

I'm closing this based on the referenced issue, and assuming succeeds was supposed to be supersedes

@chuckha chuckha closed this Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR Blocking test(s)
4 participants