Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Blocking test(s) #271

Closed
detiber opened this issue Oct 17, 2018 · 16 comments
Closed

PR Blocking test(s) #271

detiber opened this issue Oct 17, 2018 · 16 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@detiber
Copy link
Member

detiber commented Oct 17, 2018

/kind feature

create and wire up pr-blocking integration tests

/assign @liztio

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 17, 2018
@liztio
Copy link
Contributor

liztio commented Oct 17, 2018

what sort of things qualify as "integration tests" here? What's our test for completion?

@detiber
Copy link
Member Author

detiber commented Oct 17, 2018

@liztio ideally we'd do a live test where we actually exercise the creation of a cluster using cluster-api and perform a minimal smoke test that the cluster appears to be functional. I do not think that this needs to include the full clusterctl workflow, since that introduces additional cleanup/teardown issues and also drastically increases the test time.

@liztio
Copy link
Contributor

liztio commented Oct 26, 2018

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 26, 2018
@detiber
Copy link
Member Author

detiber commented Oct 26, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Oct 26, 2018
@detiber detiber added this to the 20181108 milestone Oct 29, 2018
@detiber detiber modified the milestones: 20181108, 20181122 Nov 8, 2018
@chuckha chuckha removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Nov 15, 2018
@chuckha chuckha modified the milestones: 20181122, 20181206 Nov 15, 2018
@liztio
Copy link
Contributor

liztio commented Dec 4, 2018

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Dec 4, 2018
@timothysc timothysc changed the title PR Blocking integration tests PR Blocking test(s) Jan 3, 2019
@timothysc
Copy link
Member

In an ideal world we would test the following on a per PR basis:

  • [MVP] Behavioral Tests
    • Infrastructure (vpc, etc) has been stood up according to the declarative spec
      • Traffic inside of the vpc are routable
      • Check the health of etcd
      • At a minimum, we need verification of (quick-test)

As a follow on we will open an issue to enumerate the future test blocking issues.

  • [Future] Integration Tests
    • Standup, and Teardown
    • (TODO) Define the breakout here.
  • [Future] All behavioral level conformance tests are run (sonobuoy)
  • [Future] Traffic has been verified to (ingress is accessible)

@liztio
Copy link
Contributor

liztio commented Jan 9, 2019

update on this: we're blocked on better aws resource management, otherwise we'd run out of resources pretty much immediately in CI

current plan is to add AWS support to test-infra's existing resource manager, boskos

@liztio
Copy link
Contributor

liztio commented Jan 28, 2019

/blocked

@liztio
Copy link
Contributor

liztio commented Jan 28, 2019

Completion on this is blocked on kubernetes/test-infra#10693, but execution is not. Someone else could start working on tests which actually stand up AWS resources to be ready for the aforementioned issue's completion.

@liztio
Copy link
Contributor

liztio commented Jan 28, 2019

/remove-lifecycle active

@k8s-ci-robot k8s-ci-robot removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 28, 2019
@ncdc
Copy link
Contributor

ncdc commented Feb 28, 2019

@detiber please reassign to @akutz

@detiber
Copy link
Member Author

detiber commented Feb 28, 2019

/assign @akutz

@k8s-ci-robot
Copy link
Contributor

@detiber: GitHub didn't allow me to assign the following users: akutz.

Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @akutz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@detiber
Copy link
Member Author

detiber commented Mar 25, 2019

/milestone Next

@k8s-ci-robot k8s-ci-robot modified the milestones: v1alpha1, Next Mar 25, 2019
@vincepri vincepri removed their assignment Jun 21, 2019
@chuckha
Copy link
Contributor

chuckha commented Jul 1, 2019

/close

we can iterate on existing tests now!

@k8s-ci-robot
Copy link
Contributor

@chuckha: Closing this issue.

In response to this:

/close

we can iterate on existing tests now!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre pushed a commit to enxebre/cluster-api-provider-aws-2 that referenced this issue Nov 20, 2019
…onsistency

Bug 1761882: pkg/actuators/machine/actuator: Eventual-consistency wait for machines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants