-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Blocking test(s) #271
Comments
what sort of things qualify as "integration tests" here? What's our test for completion? |
@liztio ideally we'd do a live test where we actually exercise the creation of a cluster using cluster-api and perform a minimal smoke test that the cluster appears to be functional. I do not think that this needs to include the full clusterctl workflow, since that introduces additional cleanup/teardown issues and also drastically increases the test time. |
/lifecycle active |
/priority critical-urgent |
/lifecycle active |
In an ideal world we would test the following on a per PR basis:
As a follow on we will open an issue to enumerate the future test blocking issues.
|
update on this: we're blocked on better aws resource management, otherwise we'd run out of resources pretty much immediately in CI current plan is to add AWS support to test-infra's existing resource manager, boskos |
/blocked |
Completion on this is blocked on kubernetes/test-infra#10693, but execution is not. Someone else could start working on tests which actually stand up AWS resources to be ready for the aforementioned issue's completion. |
/remove-lifecycle active |
/assign @akutz |
@detiber: GitHub didn't allow me to assign the following users: akutz. Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone Next |
/close we can iterate on existing tests now! |
@chuckha: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…onsistency Bug 1761882: pkg/actuators/machine/actuator: Eventual-consistency wait for machines
/kind feature
create and wire up pr-blocking integration tests
/assign @liztio
The text was updated successfully, but these errors were encountered: