-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: eks e2e test failing as subnet name was used #4575
Conversation
Signed-off-by: Richard Case <[email protected]>
/test ? |
@richardcase: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-provider-aws-e2e-eks |
/test pull-cluster-api-provider-aws-e2e-eks-testing |
/test pull-cluster-api-provider-aws-e2e |
Signed-off-by: Richard Case <[email protected]>
/test pull-cluster-api-provider-aws-e2e-eks |
/test pull-cluster-api-provider-aws-e2e-eks-testing |
/test pull-cluster-api-provider-aws-e2e-eks |
/test pull-cluster-api-provider-aws-e2e-eks |
/test pull-cluster-api-provider-aws-test |
I'll get the failing tests fixed today |
After the recenet change around the subnets the e2e where breaking as it wasn't using the new resource id field. Signed-off-by: Richard Case <[email protected]>
5a79fff
to
e53f691
Compare
Running the e2e again: /test pull-cluster-api-provider-aws-e2e-eks |
/test pull-cluster-api-provider-aws-apidiff-main |
Lets also check the non-EKS e2e: /test pull-cluster-api-provider-aws-e2e |
EKS and non-EKS tests passing |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-cluster-api-provider-aws-apidiff-main |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlipovetsky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4574
Special notes for your reviewer:
Checklist:
Release note: